Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved


crates/blockifier/src/blockifier_versioned_constants.rs line 1095 at r1 (raw file):

    // Validation.
    pub validate_rounding_consts: ValidateRoundingConsts,

moved, not added

Code quote:

pub validate_rounding_consts: ValidateRoundingConsts,

crates/blockifier/src/blockifier_versioned_constants.rs line 1122 at r1 (raw file):

    // L1 handler.
    pub l1_handler_version: u8,
    pub l1_handler_max_amount_bounds: GasVector,

moved, not added

Code quote:

pub l1_handler_max_amount_bounds: GasVector,

crates/blockifier/src/blockifier_versioned_constants.rs line 1126 at r1 (raw file):

    // Miscellaneous.
    pub nop_entry_point_offset: i8,
    pub os_contract_addresses: OsContractAddresses,

moved, not added

Code quote:

pub os_contract_addresses: OsContractAddresses,

crates/blockifier/src/blockifier_versioned_constants.rs line 1154 at r1 (raw file):

            gas_costs.base.step_gas_cost * entry_point_initial_budget_steps.0;
        let default_initial_gas_cost =
            gas_costs.base.step_gas_cost * default_initial_gas_cost_steps.0;

to align with other values in VersionedConstants: precompute total costs of entry_point_initial_budget and default_initial_gas_cost (i.e. multiply by step gas costs).
We use explicit destructuring (let RawStepGasCost { .. } = ..) to avoid the case where these initial costs depend on more than just steps (i.e. builtins) without the compiler complaining - if more cost types are added to these later, the compiler will catch that this computation must be updated.

Code quote:

        // Preprocess inital budget costs.
        let RawStepGasCost { step_gas_cost: entry_point_initial_budget_steps } =
            raw_constants.entry_point_initial_budget;
        let RawStepGasCost { step_gas_cost: default_initial_gas_cost_steps } =
            raw_constants.default_initial_gas_cost;
        let entry_point_initial_budget =
            gas_costs.base.step_gas_cost * entry_point_initial_budget_steps.0;
        let default_initial_gas_cost =
            gas_costs.base.step_gas_cost * default_initial_gas_cost_steps.0;

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 04926e5 to f876d75 Compare May 2, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from f1176fb to 7fa7428 Compare May 2, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from f876d75 to abf4950 Compare May 5, 2025 11:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 7fa7428 to c16fe40 Compare May 5, 2025 11:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from abf4950 to 67ed994 Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from c16fe40 to c43084e Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 67ed994 to 747017c Compare May 5, 2025 13:09
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from c43084e to 61d3c36 Compare May 5, 2025 13:09
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 747017c to 506edf5 Compare May 6, 2025 12:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 61d3c36 to 57e43fa Compare May 6, 2025 12:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 506edf5 to 04c1b5c Compare May 6, 2025 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 57e43fa to 08d614a Compare May 6, 2025 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 04c1b5c to 4c76a10 Compare May 6, 2025 14:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 08d614a to b5137b2 Compare May 6, 2025 14:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 4c76a10 to f8f640e Compare May 6, 2025 14:52
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from b5137b2 to fe14b9c Compare May 6, 2025 14:52
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from f8f640e to 003d36b Compare May 8, 2025 09:47
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 8aab23f to 3e09fd3 Compare May 15, 2025 10:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 1ddf989 to 38ff341 Compare May 19, 2025 22:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 3e09fd3 to a4644d7 Compare May 19, 2025 22:13
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 38ff341 to b852e7c Compare May 25, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from a4644d7 to a67d1bc Compare May 25, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from b852e7c to 74960f5 Compare May 25, 2025 15:27
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from a67d1bc to cc2ca31 Compare May 25, 2025 15:27
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 74960f5 to d0c6309 Compare May 25, 2025 17:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from cc2ca31 to 50efaa4 Compare May 25, 2025 17:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from d0c6309 to 159eee4 Compare May 26, 2025 08:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 50efaa4 to abb42e2 Compare May 26, 2025 08:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 159eee4 to 1a034f9 Compare May 26, 2025 09:52
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from abb42e2 to 6dfd8c0 Compare May 26, 2025 09:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 1a034f9 to 0dfdac8 Compare May 26, 2025 11:54
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from 6dfd8c0 to f5aca3e Compare May 26, 2025 11:54
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 26, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts branch from 0dfdac8 to 2a5e8c8 Compare May 26, 2025 14:49
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_blockifier_expose_more_fields_in_osconstants branch from f5aca3e to ae11937 Compare May 26, 2025 14:50
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-01-feat_apollo_infra_utils_add_cairo-format_to_verified_cairo0_scripts to main-v0.14.0 May 27, 2025 08:47
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 27, 2025
Merged via the queue into main-v0.14.0 with commit 166f7b7 May 27, 2025
29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants