Skip to content

test(apollo_starknet_os_program): add OS constants test #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 4 commits into from
May 30, 2025
Merged

test(apollo_starknet_os_program): add OS constants test #6274

dorimedini-starkware merged 4 commits into from
May 30, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented May 1, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented May 1, 2025

This change is Reviewable

This was referenced May 1, 2025
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented May 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware mentioned this pull request May 1, 2025
Merged
@github-actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from ab2b8ce to f046919 Compare May 1, 2025 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 1b132cd to 1e3cfe3 Compare May 1, 2025 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from f046919 to 49a4272 Compare May 1, 2025 14:43
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 1e3cfe3 to 5db3b08 Compare May 1, 2025 14:43
@dorimedini-starkware dorimedini-starkware changed the title test(apollo_starknet_os_program): OS constants test test(apollo_starknet_os_program): add OS constants test May 1, 2025
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch 4 times, most recently from 122bde7 to 53ef04c Compare May 2, 2025 14:13
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 49a4272 to bd62713 Compare May 2, 2025 14:19
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 53ef04c to b367524 Compare May 2, 2025 14:19
@github-actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

Benchmark movements: No major performance changes detected.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from bd62713 to f584300 Compare May 5, 2025 11:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from b367524 to b4f3245 Compare May 5, 2025 11:01
@github-actions
Copy link

github-actions bot commented May 5, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.962 ms 35.486 ms 36.112 ms]
change: [+1.1046% +2.4982% +4.1124%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from f584300 to 0ba7ba3 Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from b4f3245 to 682814a Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 0ba7ba3 to 24ca068 Compare May 5, 2025 13:10
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 8b26873 to 80dbbe5 Compare May 26, 2025 08:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from bbcd655 to b3e6c02 Compare May 26, 2025 08:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 80dbbe5 to 7df553d Compare May 26, 2025 09:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from b3e6c02 to 9b8306a Compare May 26, 2025 09:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 7df553d to 12d34d6 Compare May 26, 2025 11:54
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 9b8306a to a337f63 Compare May 26, 2025 11:55
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 26, 2025 14:19
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 12d34d6 to 8d0da2b Compare May 26, 2025 14:50
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from a337f63 to 4a2fb35 Compare May 26, 2025 14:50
dorimedini-starkware
dorimedini-starkware commented May 26, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

a discussion (no related file):
py side

dorimedini-starkware
dorimedini-starkware commented May 26, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

py side

new py side

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 8d0da2b to 15ded16 Compare May 27, 2025 10:29
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch 2 times, most recently from caac33d to 854e41a Compare May 27, 2025 10:32
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo to main-v0.14.0 May 27, 2025 10:32
dorimedini-starkware
dorimedini-starkware commented May 27, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

AvivYossef-starkware
AvivYossef-starkware approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 854e41a to 7b14bab Compare May 28, 2025 15:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 7b14bab to 0f85e49 Compare May 29, 2025 14:02
dorimedini-starkware
dorimedini-starkware commented May 29, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r3, 1 of 3 files at r4, 2 of 3 files at r8, 1 of 1 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 30, 2025
Merged via the queue into main-v0.14.0 with commit c1942ce May 30, 2025
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AvivYossef-starkware AvivYossef-starkware AvivYossef-starkware approved these changes

@avivg-starkware avivg-starkware Awaiting requested review from avivg-starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @AvivYossef-starkware