-
Notifications
You must be signed in to change notification settings - Fork 65
feat(apollo_starknet_os_program): hard-code gas costs in constants.cairo #6270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b217371 to
d564695
Compare
e971533 to
7dd5983
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
a discussion (no related file):
VersionedConstants does not expose the "components" of syscall gas costs: only the base cost (u64) and linear factor (u64).
To avoid using RawVersionedConstants and duplicating the logic that computes the flat cost from the raw cost components (already done in impl From<RawVersionedConstants> for VersionedConstants), we hard-code the computed costs in constants.cairo.
d564695 to
b1f0aa5
Compare
7dd5983 to
3e09a83
Compare
b1f0aa5 to
975ab60
Compare
3e09a83 to
96e007c
Compare
975ab60 to
b565de1
Compare
96e007c to
4755ac1
Compare
b565de1 to
9291eb0
Compare
4755ac1 to
38eb8b0
Compare
9291eb0 to
f692f48
Compare
38eb8b0 to
bc8d7a3
Compare
f692f48 to
d7de69e
Compare
bc8d7a3 to
cb19a5a
Compare
d7de69e to
44caee2
Compare
cb19a5a to
48e6983
Compare
44caee2 to
a8e8e7f
Compare
48e6983 to
c3e64f2
Compare
c09bfad to
0130640
Compare
b3ee95f to
f69f744
Compare
0130640 to
13920fd
Compare
f69f744 to
eda0355
Compare
13920fd to
d37f6c7
Compare
eda0355 to
2555db3
Compare
d37f6c7 to
535729d
Compare
2555db3 to
87d7e6b
Compare
535729d to
33e4bf3
Compare
87d7e6b to
53e128a
Compare
33e4bf3 to
56c4333
Compare
53e128a to
2c1e7c9
Compare
56c4333 to
555c614
Compare
2c1e7c9 to
d63a41c
Compare
555c614 to
5a7574f
Compare
d63a41c to
9968c05
Compare
5a7574f to
e3082f2
Compare
9968c05 to
5c4c19d
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
5c4c19d to
7440097
Compare
|
Artifacts upload workflows: |
|
Benchmark movements: No major performance changes detected. |

No description provided.