feat(apollo_starknet_os_program): add fixer for OS constants test

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• test(apollo_starknet_os_program): test all non-deprecated syscalls have gas costs #6639
• feat(apollo_starknet_os_program): add fixer for OS constants test #6275 👈 (View in Graphite)
• test(apollo_starknet_os_program): add OS constants test #6274
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[avivg-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/apollo_starknet_os_program/src/constants_test.rs line 215 at r3 (raw file):

/// ```bash
/// FIX_OS_CONSTANTS=1 cargo test -p apollo_starknet_os_program test_os_constants
/// ```

Perhaps more explicit?

Suggestion:

/// Test that `constants.cairo` generated from OS versioned constants, matches the existing file.
/// To fix this test, run:
/// ```bash
/// FIX_OS_CONSTANTS=1 cargo test -p apollo_starknet_os_program test_os_constants
/// ```

---

crates/apollo_starknet_os_program/src/constants_test.rs line 219 at r3 (raw file):

fn test_os_constants() {
    verify_cairo0_compiler_deps();
    let generated = generate_constants_file();

Also, for extra clarity
(not sure if needed, perhaps the function's doc might be sufficient)

My main goal is to make it visible in the function which 'source' file drives which 'output' file.

Anyway, non-blocking, as you see fit, is great.

Suggestion:

// generate `constants.cairo` from the current OS constants.
let generated = generate_constants_file();

[avivg-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[graphite-app]

Merge activity

• May 30, 9:36 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.