Skip to content

Automated backport of #1297: Replace slash with dot in ConfigMap keys for K8s compliance#1298

Merged
skitt merged 2 commits intosubmariner-io:release-0.23from
tpantelis:automated-backport-of-#1297-upstream-release-0.23
Mar 2, 2026
Merged

Automated backport of #1297: Replace slash with dot in ConfigMap keys for K8s compliance#1298
skitt merged 2 commits intosubmariner-io:release-0.23from
tpantelis:automated-backport-of-#1297-upstream-release-0.23

Conversation

@tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Feb 27, 2026

Backport of #1297 on release-0.23.

#1297: Replace slash with dot in ConfigMap keys for K8s compliance

For details on the backport process, see the backport requests page.

Summary by CodeRabbit

  • Bug Fixes
    • Updated configuration key formatting to use dot notation instead of slash notation for improved consistency in configuration lookups.

Signed-off-by: Paddy <padgupta@microsoft.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1298/tpantelis/automated-backport-of-#1297-upstream-release-0.23

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15cd1a7 and 44f486c.

📒 Files selected for processing (1)
  • pkg/workqueue/config.go

Walkthrough

Changed the key separator in the ToConfigMapDataKey function from slash to dot notation, affecting how configuration keys are formatted and looked up in the global config map.

Changes

Cohort / File(s) Summary
Key Separator Update
pkg/workqueue/config.go
Modified ToConfigMapDataKey to use dot (.) separator instead of slash (/) for constructing configuration map keys.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • skitt
  • vthapar
  • sridhargaddam
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing slashes with dots in ConfigMap keys for Kubernetes compliance, which directly matches the code change in pkg/workqueue/config.go.
Actionable Comments Resolved ✅ Passed The pull request contains no actionable comments requiring resolution. Only an automated informational notification from submariner-bot is present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

skitt added a commit to tpantelis/admiral that referenced this pull request Mar 2, 2026
skitt added a commit to tpantelis/admiral that referenced this pull request Mar 2, 2026
skitt added a commit to tpantelis/admiral that referenced this pull request Mar 2, 2026
@skitt skitt enabled auto-merge (rebase) March 2, 2026 15:47
@skitt skitt merged commit 7b630f2 into submariner-io:release-0.23 Mar 2, 2026
18 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1298/tpantelis/automated-backport-of-#1297-upstream-release-0.23]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants