Skip to content

Comments

feat: remove legacy project columns, old settings tables, and app_id defaults#5096

Draft
Flo4604 wants to merge 3 commits intofeat/multi-app-control-planefrom
feat/multi-app-cleanup
Draft

feat: remove legacy project columns, old settings tables, and app_id defaults#5096
Flo4604 wants to merge 3 commits intofeat/multi-app-control-planefrom
feat/multi-app-cleanup

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Feb 19, 2026

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Feb 20, 2026 0:22am
engineering Ready Ready Preview, Comment Feb 20, 2026 0:22am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/multi-app-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author

Flo4604 commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from f6561cf to d099c0e Compare February 19, 2026 19:14
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from 8a14ae8 to 1b51dbf Compare February 19, 2026 19:14
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from d099c0e to 8c1916a Compare February 19, 2026 19:24
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from 1b51dbf to 86a3b73 Compare February 19, 2026 19:24
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from 8c1916a to 991c9cd Compare February 19, 2026 19:58
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from 991c9cd to 89a7f57 Compare February 19, 2026 20:10
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from 89a7f57 to bd8fa41 Compare February 19, 2026 20:40
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from bd8fa41 to fe8709d Compare February 20, 2026 04:46
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from 86a3b73 to 3fd482f Compare February 20, 2026 04:46
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from 3fd482f to a8265b1 Compare February 20, 2026 04:54
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from fe8709d to 9b685a1 Compare February 20, 2026 04:54
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from a8265b1 to ebf6205 Compare February 20, 2026 07:39
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from bf0fcfc to 692cde4 Compare February 20, 2026 07:39
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from ebf6205 to 7ebf639 Compare February 20, 2026 08:15
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from 692cde4 to 06d4de7 Compare February 20, 2026 08:15
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from 06d4de7 to b3af789 Compare February 20, 2026 10:34
@Flo4604 Flo4604 force-pushed the feat/multi-app-control-plane branch from 7ebf639 to de78fbf Compare February 20, 2026 10:34
…defaults

Drop deprecated columns (live_deployment_id, is_rolled_back, depot_project_id)
from projects table. Delete environment_build_settings and
environment_runtime_settings tables/queries in favor of app-scoped equivalents.
Remove DEFAULT '' from app_id columns. Migrate all Go code to use app-scoped
queries: github_webhook, verify_handler, deployment_state, build, seed files.
The cleanup branch incorrectly removed the is_rolled_back column from
the apps table and the dashboard's rollback badge. This restores it:
- Schema: keep is_rolled_back boolean on apps table
- Go handlers: rollback sets true, promote/deploy set false
- Dashboard: restore "Rolled Back" badge and warning row styling
- Docs: update workflow description to match explicit flag approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant