Skip to content

Comments

feat: out-of-order webhook delivery guard#5097

Draft
Flo4604 wants to merge 1 commit intofeat/multi-app-cleanupfrom
feat/webhook-out-of-order-guard
Draft

feat: out-of-order webhook delivery guard#5097
Flo4604 wants to merge 1 commit intofeat/multi-app-cleanupfrom
feat/webhook-out-of-order-guard

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Feb 19, 2026

Summary

  • Adds a timestamp guard in the deploy workflow's auto-promote logic to prevent older git commits from overtaking newer ones when webhooks arrive out of order
  • Only compares timestamps when both the new and current live deployment have valid git commit timestamps (git-sourced deployments)
  • CLI/docker uploads (no timestamp) skip the guard entirely and auto-promote as before

Test plan

  • Deploy commit A (timestamp 100), verify it auto-promotes
  • Deploy commit B (timestamp 200), verify it auto-promotes (newer)
  • Deploy commit C (timestamp 50), verify it does NOT auto-promote (older than live)
  • Deploy via CLI (no timestamp), verify auto-promote still works

Stack: 1/3

@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Feb 20, 2026 0:22am
engineering Ready Ready Preview, Comment Feb 20, 2026 0:22am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/webhook-out-of-order-guard

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author

Flo4604 commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Flo4604 Flo4604 marked this pull request as draft February 19, 2026 21:34
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from bd8fa41 to fe8709d Compare February 20, 2026 04:46
@Flo4604 Flo4604 force-pushed the feat/webhook-out-of-order-guard branch from 6040a5b to 9abe5bd Compare February 20, 2026 04:46
@Flo4604 Flo4604 force-pushed the feat/webhook-out-of-order-guard branch from 9abe5bd to c810ba7 Compare February 20, 2026 04:54
@Flo4604 Flo4604 force-pushed the feat/multi-app-cleanup branch from fe8709d to 9b685a1 Compare February 20, 2026 04:54
@Flo4604 Flo4604 changed the base branch from feat/multi-app-cleanup to graphite-base/5097 February 20, 2026 05:31
@Flo4604 Flo4604 force-pushed the feat/webhook-out-of-order-guard branch from c810ba7 to d1856a5 Compare February 20, 2026 08:26
@Flo4604 Flo4604 changed the base branch from graphite-base/5097 to feat/multi-app-cleanup February 20, 2026 08:26
When webhooks arrive out of order (e.g. commit@11:40, commit@11:44,
commit@11:39), the oldest commit could deploy last and get auto-promoted
to live, overtaking a newer commit. This adds a timestamp comparison
before auto-promoting: if the current live deployment has a newer git
commit timestamp, the new deployment skips auto-promote.

Only fires when both timestamps are valid (git-sourced deployments).
CLI/docker uploads (no timestamp) are unaffected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant