feat: deduplicate GitHub webhook deliveries#5098
Closed
Flo4604 wants to merge 1 commit intofeat/webhook-out-of-order-guardfrom
Closed
feat: deduplicate GitHub webhook deliveries#5098Flo4604 wants to merge 1 commit intofeat/webhook-out-of-order-guardfrom
Flo4604 wants to merge 1 commit intofeat/webhook-out-of-order-guardfrom
Conversation
Adds a check before creating a deployment to skip if one already exists for the same commit SHA + app + environment. This prevents duplicate deployments when GitHub retries webhook deliveries. Also extracts X-GitHub-Delivery header and logs it throughout the webhook handler for observability.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
19 tasks
Member
Author
|
Dedup handled naturally by Restate idempotency keys in feat/webhook-restate — this SQL-level check is redundant. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists
Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtmake fmton/godirectoryconsole.logsgit pull origin mainAppreciated