stty: Changing shell command to add recognizing a TTY for stty tests

[ChrisDryden]

Been looking into examples of how other repositories using Github actions are able to test things that require the tests recognizing that a TTY session exists. This example comes from: https://github.com/gfx/example-github-actions-with-tty and is used in a bunch of other open source projects such as: https://cocalc.com/github/Ardupilot/ardupilot/blob/master/.github/workflows/test_environment.yml

The integration test suite ran and showed that now the tests are running for stty! The tests are not passing because there is still some things to fix in STTY itself and those are being worked on in other PR's

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/stty/bad-speed. tests/stty/bad-speed is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/stty/stty. tests/stty/stty is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/stty/stty-invalid. tests/stty/stty-invalid is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/stty/stty-pairs. tests/stty/stty-pairs is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/stty/stty-row-col. tests/stty/stty-row-col is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

[ChrisDryden]

@sylvestre The "GNU testsuite comparison" is showing now that the STTY tests are not being skipped and are running! From what I can gather about the other two tests, it appears to be just flaky tests unrelated to this change. Would you be open to taking this approach to change these five tests from "Skipped" to failed?

I have other PR's open that address the failures themselves, should have these tests passing in the CI soon!

[ChrisDryden]

Added additional comments describing the change and re-based. I'm expecting it to still fail the GNU test check since it is not able to recognize a test that moved from skipped to fail.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/stty/bad-speed. tests/stty/bad-speed is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[ChrisDryden]

Darn compared to the other runs for some reason this time it only recognized the pty for one out of the five tests. Still some work to go

[ChrisDryden]

Changing it to this new format appears to consistently run the STTY tests

[codspeed-hq]

CodSpeed Performance Report

Merging #9336 will not alter performance

_{Comparing ChrisDryden:patch-1 (48ffbb7) with main (821c674)}

Summary

✅ 126 untouched
⏩ 6 skipped¹

Footnotes

1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

[ChrisDryden]

Two of the stty tests are now passing in the main branch!

[sylvestre]

Would you be open to taking this approach to change these five tests from "Skipped" to failed?

of course, failed is better than skipped!

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/stty/bad-speed. tests/stty/bad-speed is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/stty/stty. tests/stty/stty is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/stty/stty-row-col. tests/stty/stty-row-col is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/stty/stty-invalid is now passing!
Congrats! The gnu test tests/stty/stty-pairs is now passing!

[ChrisDryden]

Right now the bad-speed test is timing out making which adds too much time to the test. Once all of the stty fixes are merged this will change to seconds and should be good to merge.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/stty/stty-invalid is now passing!
Congrats! The gnu test tests/stty/stty-pairs is now passing!
Note: The gnu test tests/stty/bad-speed was skipped on 'main' but is now failing.
Note: The gnu test tests/stty/stty was skipped on 'main' but is now failing.
Note: The gnu test tests/stty/stty-row-col was skipped on 'main' but is now failing.

[ChrisDryden]

The other change to track the skipped to failing is working now!

[ChrisDryden]

I would still say not ready for merge since the bad-speed test is timing out, but once: #9490 #9516 and #9517 are in all should be passing and not be timing out