Enable i2s_codec sample on mcxn5xx_evk #96954
Conversation
Add the micfil node to nxp_mcxnx4x_common.dtsi. Signed-off-by: Vit Stanicek <[email protected]>
- add micfil clock initialization to board.c - enable micfil and da7212 codec in mcx_n5xx dts Signed-off-by: Tomas Barak <[email protected]>
- format mcx_nx4x_evk board.c Signed-off-by: Tomas Barak <[email protected]>
- add mcx_n5xx_evk/mcxn547/cpu0 to sample.yaml - add mcx_n5xx_evk/mcxn547/cpu0 configuration and overlay Signed-off-by: Tomas Barak <[email protected]>
zephyrbot
added
area: I2S
area: Samples
zephyrbot
requested review from
anangl,
butok,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
JarmouniA,
kartben,
mmahadevan108 and
nashif
|
| #define BOARD_USB_PHY_D_CAL (0x04U) | ||
| #define BOARD_USB_PHY_TXCAL45DP (0x07U) | ||
| #define BOARD_USB_PHY_TXCAL45DM (0x07U) | ||
|
|
There was a problem hiding this comment.
A commit message should be focused on why the changes is needed and less on what is does. What it does should be somehow obvious from the code (if it is not then explain it briefly in the commit message).
So here your commit message should be something like this:
board: mcx_nx4x: Fix formatting
In order to make style more consistent and code easier to read
fix some style issues:
- add enum values each on a single line
- fixes multiple whitespaces in macro definitions
Signed-off-by: Tomas Barak <[email protected]>
If those were detected by a tool (e.g checkpatch.pl) please also mention this in the commit message.
Also, this change can be marked as trivial sent in a different PR and merged faster your if current PR is delayed by some dependencies.
| @@ -0,0 +1,14 @@ | |||
| # Copyright 2025 NXP | |||
| # | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Commit message body is not giving us any extra info. We should try to use more of a natural language description of what the change is about focusing mostly on why the change is needed.
Also mention in the commit message things that are out of the ordinary which people reading the git log history might want to be aware about.
Commit title is nice and clear mostly saying what we need to now.
So, the commit message should look something like this:
samples: i2s_codec: enable i2s_codec sample for mcx_n5xx_evk
In order to test <insert your scenario here> on mcx_n5xx_evk we need to
configure dts nodes for SAI1 interface and MICFIL channels and
also enable some config options for DMA, I2S and DMIC.
Note that we are using newly introduced I2s params (bytes_per_sample, sample_widht, extra_blocks).
Signed-off-by: Tomas Barak [email protected]
| CLOCK_SetClkDiv(kCLOCK_DivAhbClk, 1U); | ||
|
|
||
| CLOCK_SetupExtClocking(BOARD_XTAL0_CLK_HZ); | ||
|
|
There was a problem hiding this comment.
I wonder if you can enable them in separate patches? If one of them breaks the system one of them would have a hard time doing a bisection.
Please use 1 commit per a logical change so that code can be easier to be reviewed and also bisection and debugging in the future be easier.
Uh oh!
There was an error while loading. Please reload this page.