ur_robot_driver: Fix compilation on Windows #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2025
urfeex
approved these changes
Jun 23, 2025
Member
urfeex
left a comment
urfeex
left a comment
There was a problem hiding this comment.
That looks good to me, thank you @traversaro
urfeex
approved these changes
Jun 25, 2025
Member
urfeex
left a comment
urfeex
left a comment
There was a problem hiding this comment.
That seems fair, thanks for providing this.
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
(cherry picked from commit 94e574f)
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
(cherry picked from commit 94e574f)
urfeex
pushed a commit
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Silvio Traversaro <[email protected]>
urfeex
pushed a commit
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Silvio Traversaro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package compiles a library, but does not expose any symbol on Windows, so if the CMake project is compiled on on Windows, no library is actually generated.
On Linux and macOS, everything compiles by default all the symbols are visible. We can achieve exactly the same behavior in Windows by setting to
ONtheCMAKE_WINDOWS_EXPORT_ALL_SYMBOLSCMake variable, so this PR sets theCMAKE_WINDOWS_EXPORT_ALL_SYMBOLSvariable toON, to ensure that the compilation works fine on Windows.Furthermore, the following fixes were also added:
-Wall -Wextraare GCC/Clang specific compilations options, so I moved it in aniffor adding GCC/Clang specific compilations options.uintdoes not exists in Windows, so we useuint32_tinsteadsleepfunction is not defined on Windows, so we usestd::this_thread::sleep_forinstead