[S1161] Enable PMD check MissingOverride

[Pankraz76]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] SUMMARY,
  where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
• Also format the first line of the commit message like [MNG-XXX] SUMMARY.
  Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

• https://sonarsource.github.io/rspec/#/rspec/S1161
• [S1161] Add missing @Override to overriding and implementing methods #2402

[Pankraz76]

tried to integrate your feedback @slachiewicz, is this any better?

[slachiewicz]

ruleset.xml should have Apache license header

[Pankraz76]

yes of course, thanks.

[slachiewicz]

Not urgent, nice to have. To me it's a manual operation to fix.
As recommended earlier, not worth trying to touch deprecated code/module.

[slachiewicz]

Small comment, issue template contains some statements about license and copyright. Please restore the template and agree to terms

[Pankraz76]

fixed <exclude-pattern>.*/compat/maven-compat/.*</exclude-pattern>.

[Pankraz76]

now the math adds up:

141 files in fixes:

• [S1161] chore: Add missing @Override to overriding and implementing methods #2446

plus

• 3 files remaining here

will finally fix this.

add up 144 files in this PR.

[adangel]

Maybe the title should be just "Enable PMD check MissingOverride"?

[Pankraz76]

whats good default value for analysisCacheLocation?

[Pankraz76]

Suggested change

	<analysisCache>true</analysisCache>
	<analysisCacheLocation>${maven.multiModuleProjectDirectory}/.pmd/.cache</analysisCacheLocation>
	<analysisCache>true</analysisCache>
	<analysisCacheLocation>${maven.multiModuleProjectDirectory}/.pmd/.cache</analysisCacheLocation>

would give here CoC value as well, to avoid confusion.
is central cache good or better dedicated to each module.

Having both variants implied, so one way is wrong already, as done different, assuming this valid as not mentioned by you @adangel.

Giving nifty default value to analysisCacheLocation wont hurt, right?

[adangel]

The defaults are documented in the documentation (surprise!) https://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#analysisCache

Not sure, what "maven.multiModuleProjectDirectory" would resolve to - probably to the same directory for every single module. Hence this config probably results in overwriting the cache file on every run - and the cache is useless.

Did you try whether the cache is working? Running "./mvnw clean verify" and again "./mvnw verify" (without clean) and comparing the timings of the pmd plugin?

The default value seems to be more sensible, as it uses a cache file per module.

[Pankraz76]

ty.

[Pankraz76]

2 sec.

clean.

init takes 4 sec.

switch working

50% gain:

[Pankraz76]

striving in chaos.