rfc filter sliders #2638
Merged
rfc filter sliders #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
force-pushed
the
rfc_filters
branch
3 times, most recently
from
5e32cea to
2c0015e
Compare
Member
|
betaflight/betaflight#11038 now changes both gyro and D static lowpass values with the sliders |
haslinghuis
force-pushed
the
rfc_filters
branch
9 times, most recently
from
8bbd171 to
f6d818d
Compare
Member
|
Not sure this is working as intended:
Reproduction:
|
haslinghuis
force-pushed
the
rfc_filters
branch
2 times, most recently
from
a8641d7 to
2bcd8eb
Compare
Member
Author
|
@mikeller Thanks for reviewing. I am fighting the fact that if we want to keep the gyro and dterm sliders enabled when changing filter checkboxes - it will move all values regardless the status of the checkboxes. Have to think about a solution for this, as I don't want to add 4 additional sliders 😛 |
haslinghuis
force-pushed
the
rfc_filters
branch
from
2bcd8eb to
36ab8f6
Compare
haslinghuis
force-pushed
the
rfc_filters
branch
4 times, most recently
from
604d288 to
732957b
Compare
haslinghuis
force-pushed
the
rfc_filters
branch
from
f008acd to
b3cacc8
Compare
haslinghuis
force-pushed
the
rfc_filters
branch
4 times, most recently
from
9d60f16 to
892fe29
Compare
Member
|
AUTOMERGE: (FAIL)
|
Fix manual input improve gyro and dterm Fix expo Fix enabling gyro dyn lpf 1 to use slider value instead of default Fix enabling dterm dyn lpf 1 to use slider value instead of default Change labels to static Refactor left panel right panel Add switches latest fixes save filter type on lp1 Remove need to save if changing switches Change lowpass html Change slider on/off behavior Fix enable/disable filter mode selectors Reworked to work with legacy and firmware sliders Change gyro warning limit to 1.4 as in 10.7 (limon)
haslinghuis
force-pushed
the
rfc_filters
branch
from
892fe29 to
d57ce5f
Compare
limonspb
previously approved these changes
Nov 19, 2021
ctzsnooze
previously approved these changes
Nov 23, 2021
Member
|
Fantastic work. End result is really intuitive and simple to use. Well worth the effort! Tested and works great. |
5 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
Sorry merge conflicts. |
blckmn
approved these changes
Nov 25, 2021
limonspb
approved these changes
Nov 25, 2021
ctzsnooze
added
Merged
and removed
Ready to Merge
Needs coordination with firmware
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
betaflight/betaflight#11038 (merged)
betaflight/betaflight#11050
Fixes: #2611
Fixes: #2620
changes
Firmware Sliders are setting Gyro and DTerm filters now.Observed behaviour with current filters:
1 Now changing lowpass 1 or static lowpass or lowpass 2 dynamic filter type disables gyro slider.
2 Now changing a lowpass 1, static or lowpass 2 values disables gyro / dterm slider.
This PR changes behavior to:
Okay - we decided to change the whole thing (@ctzsnooze thanks for functional design)
https://dev.azure.com/Betaflight/Betaflight%20Nightlies/_build/results?buildId=4419&view=artifacts&pathAsName=false&type=publishedArtifacts