bring back tests

[m7pr]

Removed 391 occurrences across 36 test files. The tests should now run without those chromium skips.

Fixes

• [Bug]: Do not skip shinytest2 tests #1440

Companion to

• Follow-up changes to TealAppDriver teal#1653
• fix pipe teal.transform#282

[github-actions]

Unit Tests Summary

    1 files     71 suites   1h 51m 46s ⏱️
  734 tests   609 ✅ 117 💤 8 ❌
2 001 runs  1 876 ✅ 117 💤 8 ❌

For more details on these failures, see this check.

Results for commit 01af5a0.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	💔	$0.23$	$+3.44$	$0$	$0$	$0$	$0$
shinytest2-tm_a_mmrm	💔	$0.66$	$+7.66$	$0$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	💔	$0.33$	$+2.67$	$0$	$0$	$0$	$0$
shinytest2-tm_g_ci	💔	$0.20$	$+1.14$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	💔	$0.25$	$+2.70$	$0$	$0$	$0$	$0$
shinytest2-tm_g_ipp	💔	$0.19$	$+2.73$	$0$	$0$	$0$	$0$
shinytest2-tm_g_km	💔	$0.38$	$+3.08$	$0$	$0$	$0$	$0$
shinytest2-tm_g_lineplot	💔	$0.14$	$+1.16$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_adverse_events	💔	$0.25$	$+1.87$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_patient_timeline	💔	$0.37$	$+4.80$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_therapy	💔	$0.33$	$+7.24$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality	💔	$0.13$	$+1.12$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality_by_worst_grade	💔	$0.12$	$+1.35$	$0$	$0$	$0$	$0$
shinytest2-tm_t_ancova	💔	$0.37$	$+1.99$	$0$	$0$	$0$	$0$
shinytest2-tm_t_binary_outcome	💔	$0.14$	$+1.37$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_by_grade	💔	$0.13$	$+1.54$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_summary	💔	$0.11$	$+2.46$	$0$	$0$	$0$	$0$
shinytest2-tm_t_exposure	💔	$0.13$	$+3.13$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_laboratory	💔	$0.22$	$+1.49$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_prior_medication	💔	$0.16$	$+1.53$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm	💔	$0.11$	$+1.29$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm_by_worst	💔	$0.17$	$+1.96$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_grade	💔	$0.13$	$+1.91$	$0$	$0$	$0$	$0$
shinytest2-tm_t_smq	💔	$0.11$	$+1.29$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary_by	💔	$0.15$	$+1.58$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_g_km	👶		$+0.13$	e2e_tm_g_km_Starts_with_collapsed_additional_plot_settings.
shinytest2-tm_g_km	💀	$0.01$	$-0.01$	e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.

Results for commit f8fe8df

♻️ This comment has been updated with latest results.

[github-actions]

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

[osenan]

I have read the CLA Document and I hereby sign the CLA

[osenan]

There is one module not passing the tests. The error seems with the app_driver function and not with the modules.
tm_t_pp_laboratory
If I run the module there are no errors

# run the module
devtools::load_all()

  data <- teal.data::teal_data()
  data <- within(data, {
    ADSL <- teal.data::rADSL
    ADLB <- teal.data::rADLB
  })
  teal.data::join_keys(data) <- teal.data::default_cdisc_join_keys[names(data)]

  app <- init_teal_app_driver(
    teal::init(
      data = data,
      modules = tm_t_pp_laboratory(
        label = "Vitals",
        dataname = "ADLB",
        parentname = "ADSL",
        patient_col = "USUBJID",
        paramcd = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("PARAMCD", "STUDYID")),
          selected = "PARAMCD"
        ),
        param = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("PARAM", "SEX")),
          selected = "PARAM"
        ),
        timepoints = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("ADY", "AGE")),
          selected = "ADY"
        ),
        anrind = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("ANRIND", "AGEU")),
          selected = "ANRIND"
        ),
        aval_var = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("AVAL", "AGE")),
          selected = "AVAL"
        ),
        avalu_var = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("AVALU", "SEX")),
          selected = "AVALU"
        ),
        pre_output = NULL,
        post_output = NULL
      )
    )
    
 shinyApp(app$ui, app$server)

The app looks ok

On the other hand if I run the app with the init_teal_app_driver as all e2e tests it fails.

devtools::load_all()
library(shinytest2)
source("tests/testthat/helper-TealAppDriver.R")

app_driver_tm_t_pp_laboratory <- function() {
  data <- teal.data::teal_data()
  data <- within(data, {
    ADSL <- teal.data::rADSL
    ADLB <- teal.data::rADLB
  })
  teal.data::join_keys(data) <- teal.data::default_cdisc_join_keys[names(data)]

  init_teal_app_driver(
    teal::init(
      data = data,
      modules = tm_t_pp_laboratory(
        label = "Vitals",
        dataname = "ADLB",
        parentname = "ADSL",
        patient_col = "USUBJID",
        paramcd = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("PARAMCD", "STUDYID")),
          selected = "PARAMCD"
        ),
        param = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("PARAM", "SEX")),
          selected = "PARAM"
        ),
        timepoints = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("ADY", "AGE")),
          selected = "ADY"
        ),
        anrind = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("ANRIND", "AGEU")),
          selected = "ANRIND"
        ),
        aval_var = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("AVAL", "AGE")),
          selected = "AVAL"
        ),
        avalu_var = teal.transform::choices_selected(
          choices = teal.transform::variable_choices(data[["ADLB"]], c("AVALU", "SEX")),
          selected = "AVALU"
        ),
        pre_output = NULL,
        post_output = NULL
      )
    )
  )
}

# run line by line, check with app_driver$view()
app_driver <- app_driver_tm_t_pp_laboratory()
app_view()

I see this:

[osenan]

By running again the tests on my machine is passing.

I suggest to fix lintrs, merge teal and teal.transform and see if in main is passing. We have also to remove the check on other branches that are not main