feat(apollo_starknet_os_program): add test contracts, add dumper in CLI

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(apollo_starknet_os_program): add test contracts, add dumper in CLI #5946 : 2 dependent PRs (#5877 , #6069 ) 👈 (View in Graphite)
• feat(apollo_starknet_os_program): compile programs asynchronously #5945
• feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 1 other dependent PR (#5944 )
• feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
• test(ci): prepare apollo_starknet_os_program for publishing #5933
• feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
• feat(apollo_starknet_os_program): add fixer for program hash test #5875
• feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
• feat(apollo_starknet_os_program): define and implement static Program #5873
• fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TzahiTaub]

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/apollo_starknet_os_program/build/compile_program.rs line 43 at r2 (raw file):

    task_set.spawn(compile_and_output_program(
        out_dir,
        "starkware/starknet/core/os/state/aliases_test.cairo",

Const. And later on - an enum similar to the blockifier's FeatureContract.

Code quote:

"starkware/starknet/core/os/state/aliases_test.cairo",

---

crates/apollo_starknet_os_program/src/lib.rs line 13 at r2 (raw file):

pub mod program_hash;
#[cfg(feature = "test_programs")]
pub mod test_programs;

Is this needed?

Code quote:

#[cfg(feature = "test_programs")]
pub mod test_programs;

---

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs line 119 at r2 (raw file):

    let bytes = match program {
        ProgramToDump::Aggregator => AGGREGATOR_PROGRAM_BYTES,
        ProgramToDump::AliasesTest => ALIASES_TEST_BYTES,

Possibly condition, see the comment below.

Code quote:

ProgramToDump::AliasesTest => ALIASES_TEST_BYTES,

---

crates/starknet_committer_and_os_cli/src/os_cli/run_os_cli.rs line 31 at r2 (raw file):

pub enum ProgramToDump {
    Aggregator,
    AliasesTest,

Shoudn't this be under #[cfg(feature = "test_programs")] as well?
If you only want to be able to recompile with this feature, but dump without it - maybe change the name of the feature. Otherwise, add the condition.

[dorimedini-starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @TzahiTaub)

---

crates/apollo_starknet_os_program/build/compile_program.rs line 43 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Const. And later on - an enum similar to the blockifier's FeatureContract.

see comment in previous PR - same question (this is still the build script)

---

crates/apollo_starknet_os_program/src/lib.rs line 13 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Is this needed?

the CLI crate includes an option to dump the aliases_test.cairo compiled program, which I will later use to remove the cairo code from the main repo

---

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs line 119 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Possibly condition, see the comment below.

see below

---

crates/starknet_committer_and_os_cli/src/os_cli/run_os_cli.rs line 31 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Shoudn't this be under #[cfg(feature = "test_programs")] as well?
If you only want to be able to recompile with this feature, but dump without it - maybe change the name of the feature. Otherwise, add the condition.

the CLI crate activates the test_programs feature of the OS program crate,
but no reason for the CLI crate to have this feature - it's "always on"

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/apollo_starknet_os_program/build/main.rs line 18 at r2 (raw file):

    let mut task_set = tokio::task::JoinSet::new();
    #[cfg(feature = "test_programs")]

I'm not sure how much the recompile-if of build scripts can be configured, but if you know how to bind the test_program feature with the test contracts (i.e., that if only a test contract was changed and we don't use the test_program feature - we won't run this scripts) - please do.

Code quote:

#[cfg(feature = "test_programs")]

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/apollo_starknet_os_program/build/main.rs line 18 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I'm not sure how much the recompile-if of build scripts can be configured, but if you know how to bind the test_program feature with the test contracts (i.e., that if only a test contract was changed and we don't use the test_program feature - we won't run this scripts) - please do.

IDK how to do that, and I think it's overkill - if you make a change to the test contract, you should be using the feature, or you are not testing your changes

[graphite-app]

Merge activity

• Jun 5, 11:35 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[dorimedini-starkware]

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)