feat(apollo_starknet_os_program): compile programs asynchronously

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(apollo_starknet_os_program): add test contracts, add dumper in CLI #5946 : 2 dependent PRs (#5877 , #6069 )
• feat(apollo_starknet_os_program): compile programs asynchronously #5945 👈 (View in Graphite)
• feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 1 other dependent PR (#5944 )
• feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
• test(ci): prepare apollo_starknet_os_program for publishing #5933
• feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
• feat(apollo_starknet_os_program): add fixer for program hash test #5875
• feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
• feat(apollo_starknet_os_program): define and implement static Program #5873
• fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-04-19T15:07:17Z
• Started at 2025-04-19T17:27:40Z
• Started at 2025-04-22T13:12:34Z
• Started at 2025-04-23T14:45:14Z
• Started at 2025-04-23T15:07:10Z
• Started at 2025-04-23T15:19:35Z
• Started at 2025-04-24T09:46:20Z
• Started at 2025-04-28T17:35:56Z
• Started at 2025-04-28T18:50:24Z
• Started at 2025-04-28T18:53:23Z
• Started at 2025-04-28T19:57:39Z
• Started at 2025-04-29T06:35:03Z
• Started at 2025-04-30T15:12:20Z
• Started at 2025-04-30T15:24:49Z
• Started at 2025-04-30T17:50:45Z
• Started at 2025-04-30T18:54:30Z
• Started at 2025-04-30T21:13:20Z
• Started at 2025-05-01T09:43:02Z
• Started at 2025-05-01T09:46:03Z
• Started at 2025-05-05T11:32:59Z
• Started at 2025-05-05T12:54:37Z
• Started at 2025-05-06T12:27:39Z
• Started at 2025-05-06T12:54:20Z
• Started at 2025-05-06T13:30:53Z
• Started at 2025-05-06T14:10:39Z
• Started at 2025-05-06T14:27:13Z
• Started at 2025-05-06T14:58:58Z
• Started at 2025-05-08T09:24:30Z
• Started at 2025-05-08T09:53:43Z
• Started at 2025-05-08T16:13:33Z
• Started at 2025-05-08T17:36:03Z
• Started at 2025-05-09T09:35:25Z
• Started at 2025-05-09T09:47:14Z
• Started at 2025-05-09T12:46:24Z
• Started at 2025-05-09T12:59:52Z
• Started at 2025-05-09T13:08:14Z
• Started at 2025-05-11T09:50:24Z
• Started at 2025-05-11T11:13:04Z
• Started at 2025-05-11T12:22:23Z
• Started at 2025-05-15T10:18:54Z
• Started at 2025-05-15T10:46:49Z
• Started at 2025-05-19T22:11:47Z
• Started at 2025-05-25T14:54:45Z
• Started at 2025-05-25T15:26:57Z
• Started at 2025-05-25T17:10:36Z
• Started at 2025-05-26T09:51:47Z
• Started at 2025-05-26T11:52:36Z
• Started at 2025-05-26T13:11:24Z
• Started at 2025-05-26T13:44:12Z
• Started at 2025-05-26T14:52:02Z
• Started at 2025-05-27T07:57:26Z
• Started at 2025-05-27T08:36:51Z
• Started at 2025-05-27T10:25:38Z
• Started at 2025-05-27T11:50:06Z
• Started at 2025-05-27T20:52:34Z
• Started at 2025-05-27T20:54:24Z
• Started at 2025-05-28T09:02:28Z
• Started at 2025-05-28T15:07:11Z
• Started at 2025-06-03T07:48:24Z
• Started at 2025-06-03T09:22:42Z
• Started at 2025-06-03T15:32:22Z
• Started at 2025-06-04T14:10:48Z

[TzahiTaub]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/apollo_starknet_os_program/build/main.rs line 20 at r2 (raw file):

    task_set.spawn(compile_program::compile_and_output_program(
        out_dir.clone(),
        "starkware/starknet/core/os/os.cairo",

Please const the OS and Agg paths.
Lat on - I think we should have an enum with methods for the OS and Aggregator with all const data (that will also replace the ProgramToDump enum in the cli).

Code quote:

"starkware/starknet/core/os/os.cairo",

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/apollo_starknet_os_program/build/main.rs line 20 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Please const the OS and Agg paths.
Lat on - I think we should have an enum with methods for the OS and Aggregator with all const data (that will also replace the ProgramToDump enum in the cli).

this is the build script - so we can't use objects from here in external crates, and we can't use constants defined in the crate's lib.rs and it's imports.
a workaround is to define a paths.rs file with just string const definitions, declare it in lib.rs, and "paste" it here in the build script with include_str!; e.g. what we do here. Is that what you meant? or do you have another idea?

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/apollo_starknet_os_program/build/main.rs line 20 at r2 (raw file):

Previously, dorimedini-starkware wrote…

this is the build script - so we can't use objects from here in external crates, and we can't use constants defined in the crate's lib.rs and it's imports.
a workaround is to define a paths.rs file with just string const definitions, declare it in lib.rs, and "paste" it here in the build script with include_str!; e.g. what we do here. Is that what you meant? or do you have another idea?

Nope, wasn't familiar with it, no need to make a const file. I do think you should const the paths in this file to appear in the head of the file.
BTW, the script has no rerun-if trigger which means it will be rerun for every change. Better aim it to the internal starknet dir.

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/apollo_starknet_os_program/build/main.rs line 20 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Nope, wasn't familiar with it, no need to make a const file. I do think you should const the paths in this file to appear in the head of the file.
BTW, the script has no rerun-if trigger which means it will be rerun for every change. Better aim it to the internal starknet dir.

I think it should rerun on every change in the crate; if you change the recompilation logic you would also want to recompile, right?