feat(apollo_starknet_os_program): define and implement static ProgramHash

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 2 dependent PRs (#5944 , #5945 )
• feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
• test(ci): prepare apollo_starknet_os_program for publishing #5933
• feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
• feat(apollo_starknet_os_program): add fixer for program hash test #5875
• feat(apollo_starknet_os_program): define and implement static ProgramHash #5874 👈 (View in Graphite)
• feat(apollo_starknet_os_program): define and implement static Program #5873
• fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-04-15T14:13:20Z
• Started at 2025-04-15T14:31:34Z
• Started at 2025-04-15T14:55:47Z
• Started at 2025-04-15T15:08:56Z
• Started at 2025-04-15T15:49:02Z
• Started at 2025-04-15T16:15:35Z
• Started at 2025-04-15T16:32:47Z
• Started at 2025-04-16T07:31:28Z
• Started at 2025-04-16T09:43:48Z
• Started at 2025-04-16T09:53:57Z
• Started at 2025-04-16T10:12:04Z
• Started at 2025-04-16T10:22:46Z
• Started at 2025-04-16T10:37:51Z
• Started at 2025-04-16T10:52:25Z
• Started at 2025-04-16T10:55:17Z
• Started at 2025-04-16T11:57:55Z
• Started at 2025-04-16T12:10:58Z
• Started at 2025-04-16T12:22:31Z
• Started at 2025-04-16T13:27:08Z
• Started at 2025-04-16T13:47:07Z
• Started at 2025-04-16T13:56:21Z
• Started at 2025-04-16T14:00:22Z
• Started at 2025-04-16T14:05:52Z
• Started at 2025-04-16T14:28:58Z
• Started at 2025-04-16T16:28:17Z
• Started at 2025-04-16T16:50:44Z
• Started at 2025-04-17T10:04:19Z
• Started at 2025-04-17T10:13:33Z
• Started at 2025-04-17T13:52:47Z
• Started at 2025-04-17T13:58:11Z
• Started at 2025-04-18T10:05:36Z
• Started at 2025-04-18T10:15:38Z
• Started at 2025-04-18T10:53:41Z
• Started at 2025-04-22T13:11:42Z
• Started at 2025-04-23T14:44:25Z
• Started at 2025-04-23T15:06:30Z
• Started at 2025-04-23T15:18:59Z
• Started at 2025-04-24T09:45:42Z
• Started at 2025-04-28T17:35:23Z
• Started at 2025-04-28T18:49:50Z
• Started at 2025-04-28T18:52:45Z
• Started at 2025-04-28T19:57:04Z
• Started at 2025-04-29T06:34:24Z
• Started at 2025-04-29T12:59:07Z
• Started at 2025-04-30T15:11:45Z
• Started at 2025-04-30T17:50:09Z
• Started at 2025-04-30T18:53:56Z
• Started at 2025-04-30T21:12:45Z
• Started at 2025-05-01T09:42:29Z
• Started at 2025-05-01T09:45:27Z
• Started at 2025-05-05T11:32:20Z
• Started at 2025-05-05T12:54:00Z
• Started at 2025-05-06T12:27:00Z
• Started at 2025-05-06T12:53:35Z
• Started at 2025-05-06T13:30:13Z
• Started at 2025-05-06T14:10:01Z
• Started at 2025-05-06T14:26:35Z
• Started at 2025-05-06T14:58:18Z
• Started at 2025-05-08T09:23:14Z
• Started at 2025-05-08T09:52:47Z
• Started at 2025-05-08T16:12:58Z
• Started at 2025-05-08T17:35:30Z
• Started at 2025-05-09T09:34:49Z
• Started at 2025-05-09T09:46:31Z
• Started at 2025-05-11T09:49:49Z
• Started at 2025-05-11T11:12:29Z
• Started at 2025-05-11T12:21:45Z
• Started at 2025-05-15T10:18:13Z
• Started at 2025-05-15T10:46:14Z
• Started at 2025-05-19T22:11:05Z
• Started at 2025-05-25T14:54:13Z
• Started at 2025-05-25T15:26:23Z
• Started at 2025-05-25T17:10:00Z
• Started at 2025-05-26T09:50:57Z
• Started at 2025-05-26T11:52:00Z
• Started at 2025-05-26T13:10:45Z
• Started at 2025-05-26T13:43:29Z
• Started at 2025-05-26T14:51:15Z
• Started at 2025-05-27T07:56:39Z

[github-actions]

Benchmark movements: tree_computation_flow performance regressed! tree_computation_flow time: [35.606 ms 36.143 ms 36.758 ms] change: [+2.7374% +4.2896% +6.3430%] (p = 0.00 < 0.05) Performance has regressed. Found 11 outliers among 100 measurements (11.00%) 1 (1.00%) high mild 10 (10.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.573 ms 34.665 ms 34.772 ms]
change: [-4.4529% -2.9354% -1.5644%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

[TzahiTaub]

Reviewed 2 of 6 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware and @nimrod-starkware)

---

crates/apollo_starknet_os_program/src/program_hash.rs line 26 at r2 (raw file):

pub struct ProgramHash {
    os: Felt,
}

?

Suggestion:

pub struct OsProgramHash(pub Felt);

---

crates/apollo_starknet_os_program/src/program_hash.rs line 46 at r3 (raw file):

            let builtin_bytes = builtin.to_str().to_string().into_bytes();
            if builtin_bytes.len() > 32 {
                Err(ProgramHashError::BuiltinNameTooLong(*builtin))

Consider (as the problem is with the str repr and not the enum)

Suggestion:

builtin.to_str()

---

crates/apollo_starknet_os_program/src/program_hash.rs line 61 at r3 (raw file):

    let program_header = vec![
        Felt::from(BOOTLOADER_VERSION),
        Felt::from(OS_PROGRAM.get_stripped_program()?.main),

This seems like a too heavy function call (copies everything) just to get this field. I propose making this field public in the cairo-vm crate if possible, so we can do this (or a getter)

Suggestion:

(OS_PROGRAM.shared_program_data.main

[TzahiTaub]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)

[dorimedini-starkware]

Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

---

crates/apollo_starknet_os_program/src/program_hash.rs line 26 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

?

next PRs add aggregator program hashes (here)

[TzahiTaub]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)