chore(blockifier_test_utils,ci): consolidate cairo-lang version and recompile deprecated contracts

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• fix(ci): properly install python deps, in CI and docker #5902 : 2 dependent PRs (#5873 , #6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• feat(starknet_committer_and_os_cli): add command to dump OS source files #6265
• feat(apollo_starknet_os_program): add feature for exposing cairo file source map #6259
• feat(apollo_starknet_os_program): copy OS cairo code #5870
• feat(apollo_starknet_os_program): add apollo_starknet_os_program crate #5869
• feat(ci): lock pip requirements #6068
• chore(blockifier_test_utils,ci): consolidate cairo-lang version and recompile deprecated contracts #5868 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-04-15T14:30:34Z
• Started at 2025-04-15T15:08:19Z
• Started at 2025-04-15T16:14:59Z
• Started at 2025-04-17T13:51:57Z
• Started at 2025-04-17T13:57:15Z
• Started at 2025-04-18T10:52:55Z
• Started at 2025-04-22T13:10:24Z
• Started at 2025-04-23T14:43:02Z
• Started at 2025-04-23T15:18:00Z

[TzahiTaub]

Reviewed 13 of 14 files at r1, all commit messages.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

taplo.toml line 5 at r2 (raw file):

  "crates/blockifier/cairo_native/**/*.toml",
  "crates/native_blockifier/.cargo/config.toml",
  "sequencer_venv/**/*.toml",

Why should there be a toml in here?

Code quote:

"sequencer_venv/**/*.toml",

[TzahiTaub]

Reviewed 13 of 14 files at r1, all commit messages.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

taplo.toml line 5 at r2 (raw file):

  "crates/blockifier/cairo_native/**/*.toml",
  "crates/native_blockifier/.cargo/config.toml",
  "sequencer_venv/**/*.toml",

Why should there be a toml in here?

Code quote:

"sequencer_venv/**/*.toml",

[TzahiTaub]

Reviewed 13 of 14 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 181 at r2 (raw file):

        Command::new("sh").arg("-c").arg("pip freeze | grep cairo-lang").output().unwrap().stdout;
    let cairo_lang_version_untrimmed = String::from_utf8(cairo_lang_version_output).unwrap();
    let cairo_lang_version = cairo_lang_version_untrimmed.trim();

If we're here

Suggestion:

    let cairo_lang_version = String::from_utf8(cairo_lang_version_output).unwrap().trim();

---

crates/blockifier_test_utils/src/cairo_compile.rs line 189 at r2 (raw file):

            panic!("Could not find cairo-lang in {:?}.", *CAIRO0_PIP_REQUIREMENTS_FILE)
        })
        .trim();

I think it's better for the "version" to only hold the version instead of the entire string, something like the suggestion.
And even better to push it into a Semver struct with semver::Version::parse(
The ends_with check below is a bit unclear - with this you can check equality.

Suggestion:

      .trim().split("==").nth(1).expect("Missing == in cairo lang version string")

[dorimedini-starkware]

Reviewable status: 13 of 14 files reviewed, all discussions resolved (waiting on @nimrod-starkware and @TzahiTaub)

---

taplo.toml line 5 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Why should there be a toml in here?

when I remove this line, taplo fails; so, there is, somewhere in the venv. doesn't matter, we can ignore everything in this venv...

---

crates/blockifier_test_utils/src/cairo_compile.rs line 181 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

If we're here

nope:

temporary value dropped while borrowed

---

crates/blockifier_test_utils/src/cairo_compile.rs line 189 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I think it's better for the "version" to only hold the version instead of the entire string, something like the suggestion.
And even better to push it into a Semver struct with semver::Version::parse(
The ends_with check below is a bit unclear - with this you can check equality.

the split("==") forces the version to always be equality... which is not actually a bad thing, so ok.
done

[TzahiTaub]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

---

crates/blockifier_test_utils/src/cairo_compile.rs line 181 at r2 (raw file):

Previously, dorimedini-starkware wrote…

nope:

temporary value dropped while borrowed

:(