-
Notifications
You must be signed in to change notification settings - Fork 65
chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
df44274 to
7d86c6e
Compare
3ce0665 to
186d311
Compare
7d86c6e to
024acbb
Compare
186d311 to
01f24e5
Compare
024acbb to
4ef812e
Compare
01f24e5 to
ed9e2c1
Compare
4ef812e to
a3edd26
Compare
ed9e2c1 to
e099557
Compare
a3edd26 to
eb75670
Compare
e099557 to
bbedc2c
Compare
8578843 to
6ba1d92
Compare
a780f22 to
400f179
Compare
6ba1d92 to
9b3c7e6
Compare
400f179 to
9477f04
Compare
9b3c7e6 to
0e53892
Compare
9477f04 to
7243c38
Compare
0e53892 to
fff899d
Compare
7243c38 to
750f23c
Compare
fff899d to
4a07689
Compare
750f23c to
6b18469
Compare
4a07689 to
3b16ec2
Compare
6b18469 to
0710881
Compare
3b16ec2 to
b4e7f9f
Compare
0710881 to
3b4fbc0
Compare
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)
crates/apollo_infra_utils/src/cairo0_compiler.rs line 37 at r2 (raw file):
}); assert_eq!(
can you copy the changes you made in this PR into here?
and please verify the command works
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @nimrod-starkware, and @TzahiTaub)
crates/apollo_infra_utils/src/cairo0_compiler.rs line 37 at r2 (raw file):
Previously, amosStarkware wrote…
can you copy the changes you made in this PR into here?
and please verify the command works
if it's too annoying (conflicts, etc) can be done later
b4e7f9f to
384baab
Compare
3b4fbc0 to
85891bd
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)
crates/apollo_infra_utils/src/cairo0_compiler.rs line 37 at r2 (raw file):
Previously, amosStarkware wrote…
if it's too annoying (conflicts, etc) can be done later
Done.
85891bd to
e193e22
Compare
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware and @TzahiTaub)
e193e22 to
f8d0a42
Compare
Merge activity
|

No description provided.