Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Apr 15, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Apr 15, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review April 15, 2025 14:16
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from df44274 to 7d86c6e Compare April 15, 2025 14:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 3ce0665 to 186d311 Compare April 15, 2025 14:31
@dorimedini-starkware dorimedini-starkware marked this pull request as draft April 15, 2025 14:32
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 7d86c6e to 024acbb Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 186d311 to 01f24e5 Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 024acbb to 4ef812e Compare April 15, 2025 16:15
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 01f24e5 to ed9e2c1 Compare April 15, 2025 16:15
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 4ef812e to a3edd26 Compare April 17, 2025 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from ed9e2c1 to e099557 Compare April 17, 2025 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from a3edd26 to eb75670 Compare April 17, 2025 13:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from e099557 to bbedc2c Compare April 17, 2025 13:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 8578843 to 6ba1d92 Compare May 9, 2025 09:34
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from a780f22 to 400f179 Compare May 9, 2025 09:34
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 6ba1d92 to 9b3c7e6 Compare May 11, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 400f179 to 9477f04 Compare May 11, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 9b3c7e6 to 0e53892 Compare May 11, 2025 11:12
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 9477f04 to 7243c38 Compare May 11, 2025 11:12
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 0e53892 to fff899d Compare May 11, 2025 12:21
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 7243c38 to 750f23c Compare May 11, 2025 12:21
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from fff899d to 4a07689 Compare May 15, 2025 10:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 750f23c to 6b18469 Compare May 15, 2025 10:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 4a07689 to 3b16ec2 Compare May 15, 2025 10:45
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 6b18469 to 0710881 Compare May 15, 2025 10:45
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 3b16ec2 to b4e7f9f Compare May 19, 2025 22:10
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 0710881 to 3b4fbc0 Compare May 19, 2025 22:10
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)


crates/apollo_infra_utils/src/cairo0_compiler.rs line 37 at r2 (raw file):

        });

    assert_eq!(

can you copy the changes you made in this PR into here?
and please verify the command works

Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @nimrod-starkware, and @TzahiTaub)


crates/apollo_infra_utils/src/cairo0_compiler.rs line 37 at r2 (raw file):

Previously, amosStarkware wrote…

can you copy the changes you made in this PR into here?
and please verify the command works

if it's too annoying (conflicts, etc) can be done later

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from b4e7f9f to 384baab Compare May 25, 2025 14:53
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 3b4fbc0 to 85891bd Compare May 25, 2025 14:53
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)


crates/apollo_infra_utils/src/cairo0_compiler.rs line 37 at r2 (raw file):

Previously, amosStarkware wrote…

if it's too annoying (conflicts, etc) can be done later

Done.

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from 85891bd to e193e22 Compare May 25, 2025 15:25
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware and @TzahiTaub)

@dorimedini-starkware dorimedini-starkware changed the base branch from 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils to main-v0.14.0 May 25, 2025 15:54
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps branch from e193e22 to f8d0a42 Compare May 25, 2025 15:54
@graphite-app
Copy link

graphite-app bot commented May 25, 2025

Merge activity

  • May 25, 3:55 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 25, 2025
Merged via the queue into main-v0.14.0 with commit 40d46aa May 25, 2025
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants