feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876

dorimedini-starkware · 2025-04-15T14:13:32Z

No description provided.

reviewable-StarkWare · 2025-04-15T14:13:43Z

This change is

dorimedini-starkware · 2025-04-15T14:13:52Z

feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 2 dependent PRs (#5944 , #5945 )
feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
test(ci): prepare apollo_starknet_os_program for publishing #5933
feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876 👈 (View in Graphite)
feat(apollo_starknet_os_program): add fixer for program hash test #5875
feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
feat(apollo_starknet_os_program): define and implement static Program #5873
fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
feat(apollo_infra_utils): better cairo0 compiler checks #5921
chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-04-15T14:14:52Z

Artifacts upload workflows:

TzahiTaub

Reviewed 1 of 7 files at r4, 2 of 6 files at r5, 4 of 4 files at r7, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @amosStarkware and @nimrod-starkware)

.github/workflows/committer_and_os_cli_push.yml line 82 at r7 (raw file):

      - name: Build CLI binary
        run: ./build_native_in_docker.sh rustup toolchain install && cargo build -p starknet_committer_and_os_cli -r --bin starknet_committer_and_os_cli --target-dir CLI_TARGET

Is this included in the install_builld_tools script?

Code quote:

rustup toolchain install

crates/starknet_committer_and_os_cli/src/os_cli/run_os_cli.rs line 48 at r7 (raw file):

        #[clap(long, short = 'o', default_value = "stdout")]
        output_path: String,
    },

Looks like it needs to follow the same structure as the above (if this is changed in a future PR it's OK).

Code quote:

    DumpProgramHash {
        /// File path to output.
        #[clap(long, short = 'o', default_value = "stdout")]
        output_path: String,
    },

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs line 115 at r7 (raw file):

    };
    // Dumping the `Program` struct won't work - it is not deserializable via cairo-lang's Program
    // class. JSONify the raw bytes instead.

The first Program is the starknet_api struct (for Cairo 0)? Isn't this struct and the Python class compatible?

Code quote:

    // Dumping the `Program` struct won't work - it is not deserializable via cairo-lang's Program
    // class. JSONify the raw bytes instead.

dorimedini-starkware

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

.github/workflows/committer_and_os_cli_push.yml line 82 at r7 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Is this included in the install_builld_tools script?

in the bootstrap script

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs line 115 at r7 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

The first Program is the starknet_api struct (for Cairo 0)? Isn't this struct and the Python class compatible?

it's the VM struct, and no, it is not.
python->VM works, not the other way around

crates/starknet_committer_and_os_cli/src/os_cli/run_os_cli.rs line 48 at r7 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Looks like it needs to follow the same structure as the above (if this is changed in a future PR it's OK).

WDYM? what is missing?
we don't need a program param when dumping the program hash; we get the entire dict (OS + aggregator)

…led program to file

TzahiTaub

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)

crates/starknet_committer_and_os_cli/src/os_cli/run_os_cli.rs line 48 at r7 (raw file):

Previously, dorimedini-starkware wrote…

WDYM? what is missing?
we don't need a program param when dumping the program hash; we get the entire dict (OS + aggregator)

OK, switch to DumpProgramHashes instead. The two commands look equivalent, but the hashes are actually all programs' hashes in one file, and the "program" is for a specific program.

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs line 116 at r7 (raw file):

    // Dumping the `Program` struct won't work - it is not deserializable via cairo-lang's Program
    // class. JSONify the raw bytes instead.
    let os_program_json = serde_json::from_slice::<serde_json::Value>(bytes)

As this can be "any" program

Suggestion:

program_json

Signed-off-by: Dori Medini <[email protected]>

dorimedini-starkware

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

crates/starknet_committer_and_os_cli/src/os_cli/commands.rs line 116 at r7 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

As this can be "any" program

Done.

TzahiTaub

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

dorimedini-starkware

Reviewed 2 of 2 files at r8, 3 of 3 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

This was referenced Apr 15, 2025

feat(apollo_starknet_os_program): copy OS cairo code #5870

Merged

chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871

Merged

dorimedini-starkware mentioned this pull request Apr 15, 2025

feat(starknet_os): remove the program from the OS runner inputs #5877

Merged

dorimedini-starkware requested review from TzahiTaub and nimrod-starkware April 15, 2025 14:15

dorimedini-starkware self-assigned this Apr 15, 2025

dorimedini-starkware marked this pull request as ready for review April 15, 2025 14:16

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 47f7df8 to b2bea45 Compare April 15, 2025 14:31

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 83d6363 to 1dbb071 Compare April 15, 2025 14:31

dorimedini-starkware marked this pull request as draft April 15, 2025 14:32

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from b2bea45 to 1c55dd5 Compare April 15, 2025 14:55

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 1dbb071 to d9d9e5f Compare April 15, 2025 14:56

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 1c55dd5 to c438e17 Compare April 15, 2025 15:09

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from d9d9e5f to 8688f92 Compare April 15, 2025 15:09

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from c438e17 to c57c217 Compare April 15, 2025 15:49

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 8688f92 to 4061106 Compare April 15, 2025 15:49

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from c57c217 to a939bdc Compare April 15, 2025 16:15

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 4061106 to 97825d7 Compare April 15, 2025 16:15

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from a939bdc to 4ed33f4 Compare April 15, 2025 16:32

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 97825d7 to 2e6df53 Compare April 15, 2025 16:32

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 4ed33f4 to 68b8a50 Compare April 16, 2025 07:31

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from a00ac52 to 53fefdc Compare May 26, 2025 09:51

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 2ef9756 to 04364be Compare May 26, 2025 11:52

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 53fefdc to b977413 Compare May 26, 2025 11:52

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 04364be to 5106d5a Compare May 26, 2025 13:10

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from b977413 to 629c819 Compare May 26, 2025 13:11

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 5106d5a to 7e34630 Compare May 26, 2025 13:43

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 629c819 to 073ef22 Compare May 26, 2025 13:43

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 7e34630 to 62086e7 Compare May 26, 2025 14:51

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 073ef22 to f3c678e Compare May 26, 2025 14:51

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 62086e7 to f26c3f2 Compare May 27, 2025 07:56

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from f3c678e to bcb8b83 Compare May 27, 2025 07:56

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from f26c3f2 to f1e2c5e Compare May 27, 2025 08:36

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from bcb8b83 to 1dd0d61 Compare May 27, 2025 08:36

TzahiTaub approved these changes May 27, 2025

View reviewed changes

dorimedini-starkware commented May 27, 2025

View reviewed changes

dorimedini-starkware added 2 commits May 27, 2025 13:22

feat(apollo_starknet_os_program): add fixer for program hash test

12ebfab

feat(starknet_committer_and_os_cli): add command to dump the OS compi…

d1be3ca

…led program to file

dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from f1e2c5e to 12ebfab Compare May 27, 2025 10:24

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 1dd0d61 to 3ff8c06 Compare May 27, 2025 10:25

TzahiTaub requested changes May 27, 2025

View reviewed changes

fix(ci): allow service CLI access to cairo-compile

67bf78b

Signed-off-by: Dori Medini <[email protected]>

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 3ff8c06 to 67bf78b Compare May 27, 2025 11:49

dorimedini-starkware commented May 27, 2025

View reviewed changes

TzahiTaub approved these changes May 27, 2025

View reviewed changes

dorimedini-starkware changed the base branch from 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test to main-v0.14.0 May 27, 2025 21:11

dorimedini-starkware commented May 28, 2025

View reviewed changes

dorimedini-starkware added this pull request to the merge queue May 28, 2025

Merged via the queue into main-v0.14.0 with commit 3683a70 May 28, 2025
22 checks passed

github-actions bot locked and limited conversation to collaborators May 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876

feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876

Uh oh!

dorimedini-starkware commented Apr 15, 2025

Uh oh!

reviewable-StarkWare commented Apr 15, 2025

Uh oh!

dorimedini-starkware commented Apr 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876

feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876

Uh oh!

Conversation

dorimedini-starkware commented Apr 15, 2025

Uh oh!

reviewable-StarkWare commented Apr 15, 2025

Uh oh!

dorimedini-starkware commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dorimedini-starkware commented Apr 15, 2025 •

edited

Loading

github-actions bot commented Apr 15, 2025 •

edited

Loading