Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Apr 15, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review April 15, 2025 14:16
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 00e05d9 to ff0b371 Compare April 15, 2025 14:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 47f7df8 to b2bea45 Compare April 15, 2025 14:31
@dorimedini-starkware dorimedini-starkware marked this pull request as draft April 15, 2025 14:32
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from ff0b371 to 4d1905e Compare April 15, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from b2bea45 to 1c55dd5 Compare April 15, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 4d1905e to 52df3de Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 1c55dd5 to c438e17 Compare April 15, 2025 15:09
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 52df3de to 2746f5a Compare April 15, 2025 15:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from c438e17 to c57c217 Compare April 15, 2025 15:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 2746f5a to 433717f Compare April 15, 2025 16:15
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from c57c217 to a939bdc Compare April 15, 2025 16:15
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 433717f to aa3ae7a Compare April 15, 2025 16:32
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from a939bdc to 4ed33f4 Compare April 15, 2025 16:32
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from aa3ae7a to 59e66f7 Compare April 16, 2025 07:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 4ed33f4 to 68b8a50 Compare April 16, 2025 07:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 5c84d71 to ab4ef72 Compare May 25, 2025 17:10
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from e4e2c5a to 724b31e Compare May 26, 2025 08:02
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from ab4ef72 to e09ecc2 Compare May 26, 2025 08:02
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 724b31e to 7fd8590 Compare May 26, 2025 09:50
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from e09ecc2 to 2ef9756 Compare May 26, 2025 09:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 7fd8590 to 694999d Compare May 26, 2025 11:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 2ef9756 to 04364be Compare May 26, 2025 11:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 694999d to 2d08ecc Compare May 26, 2025 13:10
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 04364be to 5106d5a Compare May 26, 2025 13:10
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from 2d08ecc to ef70b43 Compare May 26, 2025 13:43
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 5106d5a to 7e34630 Compare May 26, 2025 13:43
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from ef70b43 to d37e6be Compare May 26, 2025 14:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 7e34630 to 62086e7 Compare May 26, 2025 14:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash branch from d37e6be to 97979f0 Compare May 27, 2025 07:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from 62086e7 to f26c3f2 Compare May 27, 2025 07:56
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)


crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):

            serde_json::to_string_pretty(&computed_hash).unwrap(),
        )
        .expect("Failed to write the program hash file.");

Raise the original error msg as well

Suggestion:

.unwrap_or_else(|error| panic!("Failed to write program hash file: {error:?}."));

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)


crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Raise the original error msg as well

*the

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from f26c3f2 to f1e2c5e Compare May 27, 2025 08:36
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)


crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

*the

Done.

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_fixer_for_program_hash_test branch from f1e2c5e to 12ebfab Compare May 27, 2025 10:24
@dorimedini-starkware dorimedini-starkware changed the base branch from 04-13-feat_apollo_starknet_os_program_define_and_implement_static_programhash to main-v0.14.0 May 27, 2025 10:25
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 27, 2025
Merged via the queue into main-v0.14.0 with commit 8b715d4 May 27, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants