-
Notifications
You must be signed in to change notification settings - Fork 65
feat(apollo_starknet_os_program): add fixer for program hash test #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apollo_starknet_os_program): add fixer for program hash test #5875
Conversation
00e05d9 to
ff0b371
Compare
47f7df8 to
b2bea45
Compare
ff0b371 to
4d1905e
Compare
b2bea45 to
1c55dd5
Compare
4d1905e to
52df3de
Compare
1c55dd5 to
c438e17
Compare
52df3de to
2746f5a
Compare
c438e17 to
c57c217
Compare
2746f5a to
433717f
Compare
c57c217 to
a939bdc
Compare
433717f to
aa3ae7a
Compare
a939bdc to
4ed33f4
Compare
aa3ae7a to
59e66f7
Compare
4ed33f4 to
68b8a50
Compare
5c84d71 to
ab4ef72
Compare
e4e2c5a to
724b31e
Compare
ab4ef72 to
e09ecc2
Compare
724b31e to
7fd8590
Compare
e09ecc2 to
2ef9756
Compare
7fd8590 to
694999d
Compare
2ef9756 to
04364be
Compare
694999d to
2d08ecc
Compare
04364be to
5106d5a
Compare
2d08ecc to
ef70b43
Compare
5106d5a to
7e34630
Compare
ef70b43 to
d37e6be
Compare
7e34630 to
62086e7
Compare
d37e6be to
97979f0
Compare
62086e7 to
f26c3f2
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)
crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):
serde_json::to_string_pretty(&computed_hash).unwrap(), ) .expect("Failed to write the program hash file.");
Raise the original error msg as well
Suggestion:
.unwrap_or_else(|error| panic!("Failed to write program hash file: {error:?}."));
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)
crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
Raise the original error msg as well
*the
f26c3f2 to
f1e2c5e
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)
crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
*the
Done.
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)
f1e2c5e to
12ebfab
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

No description provided.