Skip to content

feat(apollo_starknet_os_program): add apollo_starknet_os_program crate #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 1 commit into from
May 8, 2025
Merged

feat(apollo_starknet_os_program): add apollo_starknet_os_program crate #5869

dorimedini-starkware merged 1 commit into from
May 8, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Apr 15, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Apr 15, 2025

This change is Reviewable

@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Apr 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 15, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Apr 15, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware self-assigned this Apr 15, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review April 15, 2025 14:14
@dorimedini-starkware dorimedini-starkware marked this pull request as draft April 15, 2025 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-12-chore_blockifier_test_utils_ci_consolidate_cairo-lang_version_and_recompile_deprecated_contracts branch from b5d836f to e3030df Compare April 15, 2025 14:30
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from 5ec4121 to d80ae8e Compare April 15, 2025 14:30
@dorimedini-starkware dorimedini-starkware force-pushed the 04-12-chore_blockifier_test_utils_ci_consolidate_cairo-lang_version_and_recompile_deprecated_contracts branch from e3030df to 1bbf23b Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from d80ae8e to f741bb1 Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-12-chore_blockifier_test_utils_ci_consolidate_cairo-lang_version_and_recompile_deprecated_contracts branch from 1bbf23b to 9b9ee5f Compare April 15, 2025 16:14
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from f741bb1 to 1e2498c Compare April 15, 2025 16:15
This was referenced Apr 16, 2025
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 04-12-chore_blockifier_test_utils_ci_consolidate_cairo-lang_version_and_recompile_deprecated_contracts branch from 9b9ee5f to e908e85 Compare April 17, 2025 13:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from 1e2498c to 604e2be Compare April 17, 2025 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-12-chore_blockifier_test_utils_ci_consolidate_cairo-lang_version_and_recompile_deprecated_contracts branch from e908e85 to 2c846ea Compare April 17, 2025 13:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from 604e2be to bb14a01 Compare April 17, 2025 13:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from 459d786 to aeaa65c Compare April 30, 2025 17:49
@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.351 ms 35.824 ms 36.382 ms]
change: [+2.5579% +3.9448% +5.5789%] (p = 0.00 < 0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) high mild
8 (8.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [30.642 ms 30.867 ms 31.238 ms]
change: [+1.0519% +1.8338% +3.0004%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from aeaa65c to b6103b2 Compare May 1, 2025 09:44
@github-actions
Copy link

github-actions bot commented May 1, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.822 ms 35.304 ms 35.873 ms]
change: [+1.1680% +2.5071% +4.4158%] (p = 0.00 < 0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) high mild
8 (8.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from b6103b2 to 9538d5a Compare May 1, 2025 14:23
This was referenced May 1, 2025
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from 9538d5a to 27b3976 Compare May 5, 2025 10:59
@github-actions
Copy link

github-actions bot commented May 5, 2025

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [31.664 ms 32.109 ms 32.589 ms]
change: [+4.6898% +6.1682% +7.6853%] (p = 0.00 < 0.05)
Performance has regressed.
Found 17 outliers among 100 measurements (17.00%)
3 (3.00%) high mild
14 (14.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch 2 times, most recently from b490a5f to b2f2ef7 Compare May 6, 2025 12:26
@dorimedini-starkware dorimedini-starkware changed the base branch from main to 05-06-feat_ci_upgrade_cairo-lang_to_0.14.0a1 May 6, 2025 12:26
@dorimedini-starkware dorimedini-starkware mentioned this pull request May 6, 2025
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_add_apollo_starknet_os_program_crate branch from b2f2ef7 to d265de2 Compare May 6, 2025 14:51
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-06-feat_ci_upgrade_cairo-lang_to_0.14.0a1 to main May 6, 2025 14:51
TzahiTaub
TzahiTaub approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

TzahiTaub
TzahiTaub approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit d46dffc May 8, 2025
25 of 45 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TzahiTaub TzahiTaub TzahiTaub approved these changes

@nimrod-starkware nimrod-starkware Awaiting requested review from nimrod-starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @TzahiTaub