Skip to content

test(ci): prepare apollo_starknet_os_program for publishing #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 1 commit into from
May 28, 2025
Merged

test(ci): prepare apollo_starknet_os_program for publishing #5933

dorimedini-starkware merged 1 commit into from
May 28, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Apr 17, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Apr 17, 2025

This change is Reviewable

This was referenced Apr 17, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Apr 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware mentioned this pull request Apr 17, 2025
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Apr 17, 2025
@github-actions
Copy link

github-actions bot commented Apr 17, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from d3aec12 to 80a3c36 Compare April 17, 2025 13:53
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 0ce9251 to fb39974 Compare April 17, 2025 13:53
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 80a3c36 to e825e2c Compare April 17, 2025 13:58
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from fb39974 to 4285720 Compare April 17, 2025 13:58
@dorimedini-starkware dorimedini-starkware mentioned this pull request Apr 17, 2025
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from e825e2c to 54559d9 Compare April 17, 2025 18:36
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 4285720 to bca7a50 Compare April 17, 2025 18:36
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 54559d9 to fef0fee Compare April 17, 2025 18:54
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from bca7a50 to d36ae68 Compare April 17, 2025 18:54
@dorimedini-starkware dorimedini-starkware mentioned this pull request Apr 18, 2025
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from fef0fee to d2bb6a1 Compare April 18, 2025 10:05
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from d36ae68 to 1cd12cf Compare April 18, 2025 10:05
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 434c8e2 to 7a49701 Compare May 26, 2025 11:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from b977413 to 629c819 Compare May 26, 2025 13:11
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 7a49701 to 04f2b68 Compare May 26, 2025 13:11
@github-actions
Copy link

github-actions bot commented May 26, 2025 •
edited
Loading

Benchmark movements: No major performance changes detected.

@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 629c819 to 073ef22 Compare May 26, 2025 13:43
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 04f2b68 to b0f04c3 Compare May 26, 2025 13:43
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 073ef22 to f3c678e Compare May 26, 2025 14:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from b0f04c3 to 2a746c6 Compare May 26, 2025 14:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from f3c678e to bcb8b83 Compare May 27, 2025 07:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 2a746c6 to 14f58db Compare May 27, 2025 07:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from bcb8b83 to 1dd0d61 Compare May 27, 2025 08:36
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 14f58db to fc32d1d Compare May 27, 2025 08:36
TzahiTaub
TzahiTaub approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

const PARENT_BRANCH: &str = include_str!("../scripts/parent_branch.txt");
const MAIN_PARENT_BRANCH: &str = "main";

Unrelated

Suggestion:

MAIN_BRANCH

dorimedini-starkware
dorimedini-starkware commented May 27, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Unrelated

I think it's good that it matches the name of the parent_branch.txt file; how about PARENT_BRANCH? without the MAIN_?

@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 1dd0d61 to 3ff8c06 Compare May 27, 2025 10:25
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from fc32d1d to 0fdab8f Compare May 27, 2025 10:25
@dorimedini-starkware dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 3ff8c06 to 67bf78b Compare May 27, 2025 11:49
@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 0fdab8f to 9f1ec6b Compare May 27, 2025 11:49
TzahiTaub
TzahiTaub approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

Previously, dorimedini-starkware wrote…

I think it's good that it matches the name of the parent_branch.txt file; how about PARENT_BRANCH? without the MAIN_?

I think you've looked at the wrong const 🙂 . I suggest keeping the PARENT_BRANCH above, and changing the MAIN_PARENT_BRANCH that is a line below, and was probably copied from the first.

@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 9f1ec6b to c6d8279 Compare May 27, 2025 20:52
dorimedini-starkware
dorimedini-starkware commented May 27, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I think you've looked at the wrong const 🙂 . I suggest keeping the PARENT_BRANCH above, and changing the MAIN_PARENT_BRANCH that is a line below, and was probably copied from the first.

ahhh right you are
done

TzahiTaub
TzahiTaub approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from c6d8279 to 663b3bd Compare May 28, 2025 09:02
@dorimedini-starkware dorimedini-starkware changed the base branch from 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file to main-v0.14.0 May 28, 2025 09:02
dorimedini-starkware
dorimedini-starkware commented May 28, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 28, 2025
Merged via the queue into main-v0.14.0 with commit 25c4d4e May 28, 2025
25 of 45 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TzahiTaub TzahiTaub TzahiTaub approved these changes

@nimrod-starkware nimrod-starkware Awaiting requested review from nimrod-starkware

@amosStarkware amosStarkware Awaiting requested review from amosStarkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @TzahiTaub