feat(apollo_starknet_os_program): add aggregator program + program hash(es)

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 2 dependent PRs (#5944 , #5945 )
• feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937 👈 (View in Graphite)
• test(ci): prepare apollo_starknet_os_program for publishing #5933
• feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
• feat(apollo_starknet_os_program): add fixer for program hash test #5875
• feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
• feat(apollo_starknet_os_program): define and implement static Program #5873
• fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TzahiTaub]

Reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @amosStarkware and @nimrod-starkware)

---

crates/apollo_starknet_os_program/src/program_hash.rs line 25 at r2 (raw file):

#[derive(Debug, Deserialize, Serialize, PartialEq)]
pub struct ProgramHash {

?

Suggestion:

ProgramHashes

---

crates/apollo_starknet_os_program/src/program_hash.rs line 43 at r2 (raw file):

    if len > 32 {
        panic!("Data length exceeds 32 bytes.");
    }

Consider

Suggestion:

fn pad_to_32_bytes(data: &[u8]) -> Result<[u8; 32], &'static str> { {
    let len = data.len();
    if len > 32 {
         Err("Data length exceeds 32 bytes.")?;
    }
    let mut padded = [0; 32];

---

crates/apollo_starknet_os_program/src/program_hash.rs line 70 at r2 (raw file):

            } else {
                Ok(Felt::from_bytes_be(&pad_to_32_bytes(&builtin_bytes)))
            }

Consider sort of this

Suggestion:

            Ok(Felt::from_bytes_be(&pad_to_32_bytes(&builtin_bytes).unwrap_or(
                Err(ProgramHashError::BuiltinNameTooLong {
                    builtin: *builtin,
                    name: builtin.to_str().to_string(),
                })?))
            

---

crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):

fn test_program_hash() {
    let AggregatorHash { with_prefix, without_prefix } = compute_aggregator_program_hash().unwrap();
    let computed_hash = ProgramHash {

Suggestion:

computed_hashes

[dorimedini-starkware]

Reviewable status: 3 of 7 files reviewed, 3 unresolved discussions (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

---

crates/apollo_starknet_os_program/src/program_hash.rs line 25 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

?

Done.

---

crates/apollo_starknet_os_program/src/program_hash.rs line 43 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Consider

this is a test util; so I'll pass

---

crates/apollo_starknet_os_program/src/program_hash.rs line 70 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Consider sort of this

as this is a test util, I prefer to fail early

---

crates/apollo_starknet_os_program/src/program_hash_test.rs line 27 at r2 (raw file):

fn test_program_hash() {
    let AggregatorHash { with_prefix, without_prefix } = compute_aggregator_program_hash().unwrap();
    let computed_hash = ProgramHash {

Done.

[github-actions]

Benchmark movements: No major performance changes detected.

[TzahiTaub]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)

---

crates/apollo_starknet_os_program/src/program_hash_test.rs line 25 at r3 (raw file):

/// ```
#[test]
fn test_program_hash() {

Suggestion:

test_program_hashes

[TzahiTaub]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

[github-actions]

Artifacts upload workflows:

• Started at 2025-05-28T10:50:39Z

[dorimedini-starkware]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

[TzahiTaub]

Reviewed 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)