Skip to content

Conversation

@raboof
Copy link
Member

@raboof raboof commented Aug 27, 2025

The acceptance tests appear to fail because docker-compose does not exist. Likely the GHA machines have moved to the new docker compose convention. This PR attempts upgrading testcontainers, as testcontainers is what's starting docker compose, and newer versions indeed do it through the docker executable.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

The acceptance tests appear to fail because `docker-compose` does not
exist. Likely the GHA machines have moved to the new `docker compose`
convention. This attempts upgrading testcontainers, as testcontainers is
what's starting docker compose, and newer versions indeed do it through
the `docker` executable.
@raboof
Copy link
Member Author

raboof commented Aug 27, 2025

hmm this is strange:

SingleServerSNIAcceptanceTest > initializationError FAILED
    org.testcontainers.containers.ContainerLaunchException: Local Docker Compose not found. Is docker-compose on the PATH?
        at org.testcontainers.containers.LocalDockerCompose.invoke(LocalDockerCompose.java:61)
        at org.testcontainers.containers.ComposeDelegate.runWithCompose(ComposeDelegate.java:241)
        at org.testcontainers.containers.ComposeDelegate.createServices(ComposeDelegate.java:163)
        at org.testcontainers.containers.DockerComposeContainer.start(DockerComposeContainer.java:139)
        at org.apache.geode.rules.DockerComposeRule$1.evaluate(DockerComposeRule.java:102)

@raboof raboof changed the title GEODE-10459: upgrade testcontainers GEODE-10459: upgrade testcontainers from 1.17.6 to 1.21.3 Aug 27, 2025
@raboof raboof force-pushed the update-testcontainers branch from a28ded5 to 902a022 Compare August 27, 2025 14:26
To use docker v2 instead of v1.

Also use new '-' separator naming convention
@raboof raboof force-pushed the update-testcontainers branch from 902a022 to db28f8e Compare August 27, 2025 15:07
@harmoncoffee
Copy link

I see you got the acceptance tests working with this change thats great!

@raboof raboof marked this pull request as ready for review August 27, 2025 17:41
@JinwooHwang JinwooHwang self-requested a review August 27, 2025 20:38
@JinwooHwang JinwooHwang merged commit c4878a4 into apache:develop Aug 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants