-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[path_provider_foundation] Migrate XCTest to Swift Testing #10761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[path_provider_foundation] Migrate XCTest to Swift Testing #10761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the native tests from XCTest to the new Swift Testing framework. The changes are logical and correctly adopt the new APIs like @Test and #expect. I've provided one suggestion to improve test robustness by replacing force unwraps with the idiomatic #require macro from Swift Testing, which will prevent potential test crashes.
packages/path_provider/path_provider_foundation/darwin/RunnerTests/RunnerTests.swift
Outdated
Show resolved
Hide resolved
| mainGroup = 97C146E51CF9000F007C117D; | ||
| packageReferences = ( | ||
| 781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "FlutterGeneratedPluginSwiftPackage" */, | ||
| 781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage" */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xcode gonna Xcode, let it touch these files.
| @@ -1,3 +1,7 @@ | |||
| ## NEXT | |||
|
|
|||
| * Migrates XCTest to Swift Testing. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of the PRs, I would revert this and use the override label instead. These changes fall under the "unless they only affect development of the package, such as test-only changes" exemption for needing CHANGELOG changes.
Part of flutter/flutter#180787 Migrate `testDebugMode` to one parameterized tests, which show up differently in the test UI: <img width="339" height="119" alt="Screenshot 2026-01-09 at 7 51 11 PM" src="https://github.com/user-attachments/assets/9b412140-5ecf-4ec0-9ab7-55922c118e7b" /> ``` ◇ Test run started. ↳ Testing Library Version: 102 (arm64-apple-ios13.0-simulator) ◇ Suite RunnerTests started. ◇ Test debugMode(debug:expectedColor:) started. ◇ Passing 2 arguments debug → false, expectedColor → UIExtendedGrayColorSpace 0 0 to debugMode(debug:expectedColor:) ◇ Passing 2 arguments debug → true, expectedColor → UIExtendedSRGBColorSpace 1 0 0 0.5 to debugMode(debug:expectedColor:) ✔ Test debugMode(debug:expectedColor:) passed after 0.001 seconds. ✔ Suite RunnerTests passed after 0.001 seconds. ✔ Test run with 1 test passed after 0.001 seconds. ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8693093135153504353/+/u/Run_package_tests/native_test/stdout Adding CHANGELOG override per #10761 (comment) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
flutter/packages@eb9e1dc...98b0325 2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 [email protected] Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 [email protected] [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#180983) flutter/packages@eb9e1dc...98b0325 2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 [email protected] Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 [email protected] [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#180983) flutter/packages@eb9e1dc...98b0325 2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 [email protected] Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 [email protected] [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#180787
Migrate
testGet*Directorytests to one parameterized tests.https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8693104410263501761/+/u/Run_package_tests/native_test/stdout
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3