Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 10, 2026

Part of flutter/flutter#180787

Migrate testGet*Directory tests to one parameterized tests.

Test suite 'RunnerTests' started on 'Clone 1 of Flutter-iPhone - Runner (7112)'
Test case 'RunnerTests/getApplicationSupportDirectory()' passed on 'Clone 1 of Flutter-iPhone - Runner (7112)' (0.000 seconds)
Test case 'RunnerTests/directoryPath(directoryType:searchPathDirectory:)' passed on 'Clone 1 of Flutter-iPhone - Runner (7112)' (0.000 seconds)
Test case 'RunnerTests/directoryPath(directoryType:searchPathDirectory:)' passed on 'Clone 1 of Flutter-iPhone - Runner (7112)' (0.001 seconds)
Test case 'RunnerTests/directoryPath(directoryType:searchPathDirectory:)' passed on 'Clone 1 of Flutter-iPhone - Runner (7112)' (0.002 seconds)
Test case 'RunnerTests/directoryPath(directoryType:searchPathDirectory:)' passed on 'Clone 1 of Flutter-iPhone - Runner (7112)' (0.002 seconds)
Successfully ran iOS xctest for packages/path_provider/path_provider_foundation/example

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8693104410263501761/+/u/Run_package_tests/native_test/stdout

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the native tests from XCTest to the new Swift Testing framework. The changes are logical and correctly adopt the new APIs like @Test and #expect. I've provided one suggestion to improve test robustness by replacing force unwraps with the idiomatic #require macro from Swift Testing, which will prevent potential test crashes.

mainGroup = 97C146E51CF9000F007C117D;
packageReferences = (
781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "FlutterGeneratedPluginSwiftPackage" */,
781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage" */,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode gonna Xcode, let it touch these files.

@jmagman jmagman marked this pull request as ready for review January 10, 2026 01:45
@@ -1,3 +1,7 @@
## NEXT

* Migrates XCTest to Swift Testing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of the PRs, I would revert this and use the override label instead. These changes fall under the "unless they only affect development of the package, such as test-only changes" exemption for needing CHANGELOG changes.

@jmagman jmagman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 14, 2026
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026
@auto-submit auto-submit bot merged commit b3889bb into flutter:main Jan 14, 2026
81 checks passed
auto-submit bot pushed a commit that referenced this pull request Jan 14, 2026
Part of flutter/flutter#180787

Migrate `testDebugMode` to one parameterized tests, which show up differently in the test UI:

<img width="339" height="119" alt="Screenshot 2026-01-09 at 7 51 11 PM" src="https://github.com/user-attachments/assets/9b412140-5ecf-4ec0-9ab7-55922c118e7b" />

```
◇ Test run started.
↳ Testing Library Version: 102 (arm64-apple-ios13.0-simulator)
◇ Suite RunnerTests started.
◇ Test debugMode(debug:expectedColor:) started.
◇ Passing 2 arguments debug → false, expectedColor → UIExtendedGrayColorSpace 0 0 to debugMode(debug:expectedColor:)
​◇ Passing 2 arguments debug → true, expectedColor → UIExtendedSRGBColorSpace 1 0 0 0.5 to debugMode(debug:expectedColor:)
​✔ Test debugMode(debug:expectedColor:) passed after 0.001 seconds.
✔ Suite RunnerTests passed after 0.001 seconds.
✔ Test run with 1 test passed after 0.001 seconds.
```
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8693093135153504353/+/u/Run_package_tests/native_test/stdout

Adding CHANGELOG override per #10761 (comment)

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 14, 2026
flutter/packages@eb9e1dc...98b0325

2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to
Swift Testing (flutter/packages#10763)
2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest
to Swift Testing (flutter/packages#10761)
2026-01-13 [email protected] Roll Flutter from
d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784)
2026-01-13 [email protected] [google_fonts] Add
missing public API documentation (flutter/packages#10782)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
patrickBillingsley pushed a commit to patrickBillingsley/flutter that referenced this pull request Jan 14, 2026
…r#180983)

flutter/packages@eb9e1dc...98b0325

2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to
Swift Testing (flutter/packages#10763)
2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest
to Swift Testing (flutter/packages#10761)
2026-01-13 [email protected] Roll Flutter from
d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784)
2026-01-13 [email protected] [google_fonts] Add
missing public API documentation (flutter/packages#10782)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jmagman jmagman deleted the path-provider-swift-testing branch January 15, 2026 00:10
ikramhasan pushed a commit to ikramhasan/flutter that referenced this pull request Jan 15, 2026
…r#180983)

flutter/packages@eb9e1dc...98b0325

2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to
Swift Testing (flutter/packages#10763)
2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest
to Swift Testing (flutter/packages#10761)
2026-01-13 [email protected] Roll Flutter from
d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784)
2026-01-13 [email protected] [google_fonts] Add
missing public API documentation (flutter/packages#10782)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: path_provider platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants