feat(qc): parameterize in and notIn scalar list filters#5734
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2026
Merged
feat(qc): parameterize in and notIn scalar list filters#5734graphite-app[bot] merged 1 commit intomainfrom
in and notIn scalar list filters#5734graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Jan 19, 2026
Member
Author
This was referenced Jan 19, 2026
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Contributor
Wasm Query Compiler File Size
|
aqrln
force-pushed
the
aqrln-kyxlvlrlzwzx
branch
from
8ba5042 to
a723411
Compare
aqrln
force-pushed
the
aqrln-wuuzunwxxymx
branch
from
d8485ea to
fa74f5a
Compare
This was referenced Jan 20, 2026
jkomyno
approved these changes
Jan 21, 2026
Merge activity
|
Enable parameterization of the `in` and `notIn` filter fields, allowing queries like:
```typescript
prisma.user.findMany({ where: { id: { in: $ids } } })
```
Where `$ids` is a placeholder representing an entire list of values.
Changes:
1. Fix filter parsing for placeholders. Currently `in`/`notIn` with placeholders is not handled and reaches the fallback branch that panics.
2. Fix a bug in `sql-query-builder` where `NotInTemplate` with placeholder is translated to `IN` operator instead of `NOT IN`. The `InTemplate` branch has already been used by in-memory joins but the opposite branch wasn't previously used so this bug went unnoticed.
3. Mark `in`/`notIn` as parameterizable.
graphite-app
bot
force-pushed
the
aqrln-kyxlvlrlzwzx
branch
from
a723411 to
ca7749b
Compare
graphite-app
bot
force-pushed
the
aqrln-wuuzunwxxymx
branch
from
fa74f5a to
1ee2b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable parameterization of the
inandnotInfilter fields, allowing queries like:Where
$idsis a placeholder representing an entire list of values.Changes:
Fix filter parsing for placeholders. Currently
in/notInwith placeholders is not handled and reaches the fallback branch that panics.Fix a bug in
sql-query-builderwhereNotInTemplatewith placeholder is translated toINoperator instead ofNOT IN. TheInTemplatebranch has already been used by in-memory joins but the opposite branch wasn't previously used so this bug went unnoticed.Mark
in/notInas parameterizable.