Merged
Conversation
This was referenced Jan 19, 2026
Member
Author
This was referenced Jan 19, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
Wasm Query Compiler File Size
|
90018ac to
da60deb
Compare
db4c9ab to
cf61b38
Compare
aqrln
commented
Jan 20, 2026
aqrln
commented
Jan 20, 2026
cf61b38 to
b9b00f9
Compare
b9b00f9 to
93c551d
Compare
669d4a8 to
61433e2
Compare
jkomyno
approved these changes
Jan 21, 2026
jkomyno
reviewed
Jan 21, 2026
jkomyno
approved these changes
Jan 21, 2026
Merge activity
|
Implement type-aware placeholder validation which rejects placeholders in incorrect positions or with incorrect types. Previously placeholders were unconditionally accepted anywhere by the query parser, which was breaking query validation and could lead to panics in downstream code.
a96f8d5 to
8820fac
Compare
61433e2 to
541b063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implement type-aware placeholder validation which rejects placeholders in incorrect positions or with incorrect types.
Previously placeholders were unconditionally accepted anywhere by the query parser, which was breaking query validation and could lead to panics in downstream code.