Skip to content

feat(qc): implement placeholder validation#5741

Merged
1 commit merged intomainfrom
aqrln-uvzslzzyztys
Jan 28, 2026
Merged

feat(qc): implement placeholder validation#5741
1 commit merged intomainfrom
aqrln-uvzslzzyztys

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Jan 19, 2026

Implement type-aware placeholder validation which rejects placeholders in incorrect positions or with incorrect types.

Previously placeholders were unconditionally accepted anywhere by the query parser, which was breaking query validation and could lead to panics in downstream code.

Copy link
Member Author

aqrln commented Jan 19, 2026

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing aqrln-uvzslzzyztys (541b063) with aqrln-qrlyxozmryxo (8820fac)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.485MiB 3.480MiB 4.493KiB
Postgres (gzip) 1.140MiB 1.138MiB 1.998KiB
Postgres (size-optimized) 1.757MiB 1.756MiB 1.698KiB
Postgres (size-optimized, gzip) 691.571KiB 690.884KiB 703.000B
Mysql 3.437MiB 3.433MiB 4.493KiB
Mysql (gzip) 1.122MiB 1.121MiB 1.356KiB
Mysql (size-optimized) 1.727MiB 1.725MiB 1.698KiB
Mysql (size-optimized, gzip) 680.756KiB 680.054KiB 719.000B
Sqlite 3.356MiB 3.352MiB 4.493KiB
Sqlite (gzip) 1.095MiB 1.094MiB 1.419KiB
Sqlite (size-optimized) 1.682MiB 1.681MiB 1.698KiB
Sqlite (size-optimized, gzip) 664.595KiB 662.964KiB 1.631KiB
SQL Server 3.579MiB 3.575MiB 4.485KiB
SQL Server (gzip) 1.159MiB 1.157MiB 1.140KiB
SQL Server (size-optimized) 1.758MiB 1.757MiB 1.698KiB
SQL Server (size-optimized, gzip) 694.747KiB 694.159KiB 602.000B
CockroachDB 3.535MiB 3.530MiB 4.485KiB
CockroachDB (gzip) 1.159MiB 1.158MiB 1.132KiB
CockroachDB (size-optimized) 1.781MiB 1.780MiB 1.698KiB
CockroachDB (size-optimized, gzip) 701.457KiB 700.919KiB 550.000B

@aqrln aqrln force-pushed the aqrln-olznqwotvklo branch from 90018ac to da60deb Compare January 19, 2026 18:39
@aqrln aqrln force-pushed the aqrln-uvzslzzyztys branch from db4c9ab to cf61b38 Compare January 19, 2026 18:39
@aqrln aqrln added this to the 7.3.0 milestone Jan 19, 2026
@aqrln aqrln marked this pull request as ready for review January 20, 2026 07:03
@aqrln aqrln force-pushed the aqrln-uvzslzzyztys branch from cf61b38 to b9b00f9 Compare January 20, 2026 12:23
@aqrln aqrln changed the base branch from aqrln-olznqwotvklo to graphite-base/5741 January 20, 2026 12:26
@aqrln aqrln changed the base branch from graphite-base/5741 to aqrln-olznqwotvklo January 20, 2026 12:26
@aqrln aqrln changed the base branch from aqrln-olznqwotvklo to graphite-base/5741 January 20, 2026 12:27
@aqrln aqrln changed the base branch from graphite-base/5741 to aqrln-qrlyxozmryxo January 20, 2026 12:28
@aqrln aqrln marked this pull request as draft January 20, 2026 12:28
@aqrln aqrln marked this pull request as ready for review January 20, 2026 12:28
@aqrln aqrln force-pushed the aqrln-uvzslzzyztys branch from b9b00f9 to 93c551d Compare January 20, 2026 12:41
@aqrln aqrln requested a review from jkomyno January 20, 2026 12:44
@aqrln aqrln force-pushed the aqrln-uvzslzzyztys branch 2 times, most recently from 669d4a8 to 61433e2 Compare January 21, 2026 10:43
@graphite-app
Copy link

graphite-app bot commented Jan 28, 2026

Merge activity

Implement type-aware placeholder validation which rejects placeholders in incorrect positions or with incorrect types.

Previously placeholders were unconditionally accepted anywhere by the query parser, which was breaking query validation and could lead to panics in downstream code.
@graphite-app graphite-app bot force-pushed the aqrln-qrlyxozmryxo branch from a96f8d5 to 8820fac Compare January 28, 2026 13:39
@graphite-app graphite-app bot force-pushed the aqrln-uvzslzzyztys branch from 61433e2 to 541b063 Compare January 28, 2026 13:40
Base automatically changed from aqrln-qrlyxozmryxo to main January 28, 2026 15:41
@graphite-app graphite-app bot closed this pull request by merging all changes into main in f3eee96 Jan 28, 2026
@graphite-app graphite-app bot deleted the aqrln-uvzslzzyztys branch January 28, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments