Skip to content

fix(qc): don't panic on placeholders in full text search#5746

Merged
graphite-app[bot] merged 1 commit intomainfrom
aqrln-nnwpqtmklwqq
Jan 28, 2026
Merged

fix(qc): don't panic on placeholders in full text search#5746
graphite-app[bot] merged 1 commit intomainfrom
aqrln-nnwpqtmklwqq

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Jan 20, 2026

matches/not_matches operations needed to be adjusted to accept
placeholders. The corresponding fields in DMMF were already marked as
parameterizable so QC panicked in Client tests here.

Copy link
Member Author

aqrln commented Jan 20, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing aqrln-nnwpqtmklwqq (f3eee96) with aqrln-uvzslzzyztys (541b063)

Summary

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.485MiB 3.485MiB 16.000B
Postgres (gzip) 1.140MiB 1.140MiB 73.000B
Postgres (size-optimized) 1.757MiB 1.757MiB -37.000B
Postgres (size-optimized, gzip) 691.477KiB 691.573KiB -98.000B
Mysql 3.437MiB 3.437MiB -41.000B
Mysql (gzip) 1.122MiB 1.122MiB 116.000B
Mysql (size-optimized) 1.727MiB 1.727MiB -49.000B
Mysql (size-optimized, gzip) 680.822KiB 680.759KiB 64.000B
Sqlite 3.356MiB 3.356MiB -313.000B
Sqlite (gzip) 1.095MiB 1.095MiB 121.000B
Sqlite (size-optimized) 1.682MiB 1.682MiB -179.000B
Sqlite (size-optimized, gzip) 664.415KiB 664.598KiB -188.000B
SQL Server 3.579MiB 3.579MiB -697.000B
SQL Server (gzip) 1.159MiB 1.159MiB 404.000B
SQL Server (size-optimized) 1.758MiB 1.758MiB -26.000B
SQL Server (size-optimized, gzip) 694.899KiB 694.799KiB 102.000B
CockroachDB 3.535MiB 3.535MiB 16.000B
CockroachDB (gzip) 1.159MiB 1.159MiB 249.000B
CockroachDB (size-optimized) 1.781MiB 1.781MiB -37.000B
CockroachDB (size-optimized, gzip) 701.544KiB 701.453KiB 94.000B

@aqrln aqrln force-pushed the aqrln-nnwpqtmklwqq branch from b48f547 to 1f46a2b Compare January 20, 2026 22:06
@aqrln aqrln force-pushed the aqrln-uvzslzzyztys branch from 93c551d to 669d4a8 Compare January 20, 2026 22:06
@aqrln aqrln added this to the 7.3.0 milestone Jan 20, 2026
@aqrln aqrln force-pushed the aqrln-nnwpqtmklwqq branch from 1f46a2b to d5e1478 Compare January 21, 2026 10:43
@aqrln aqrln force-pushed the aqrln-uvzslzzyztys branch from 669d4a8 to 61433e2 Compare January 21, 2026 10:43
@graphite-app
Copy link

graphite-app bot commented Jan 28, 2026

Merge activity

`matches`/`not_matches` operations needed to be adjusted to accept
placeholders. The corresponding fields in DMMF were already marked as
parameterizable so QC panicked in Client tests here.
@graphite-app graphite-app bot force-pushed the aqrln-uvzslzzyztys branch from 61433e2 to 541b063 Compare January 28, 2026 13:40
@graphite-app graphite-app bot force-pushed the aqrln-nnwpqtmklwqq branch from d5e1478 to f3eee96 Compare January 28, 2026 13:40
@graphite-app graphite-app bot changed the base branch from aqrln-uvzslzzyztys to main January 28, 2026 15:42
@graphite-app graphite-app bot merged commit f3eee96 into main Jan 28, 2026
98 checks passed
@graphite-app graphite-app bot deleted the aqrln-nnwpqtmklwqq branch January 28, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments