Skip to content

refactor(qc): remove ScalarCondition::[Not]InTemplate#5735

Merged
graphite-app[bot] merged 1 commit intomainfrom
aqrln-tuxsotykylou
Jan 28, 2026
Merged

refactor(qc): remove ScalarCondition::[Not]InTemplate#5735
graphite-app[bot] merged 1 commit intomainfrom
aqrln-tuxsotykylou

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Jan 19, 2026

Remove ScalarCondition::InTemplate and ScalarCondition::NotInTemplate and instead add placeholders as the third variant in ConditionListValue. This simplifies the implementation and makes some illegal states unrepresentable (previously it was possible to construct ScalarCondition::InTemplate/ScalarCondition::NotInTemplate with arbitrary PrismaValues and with field references).

Copy link
Member Author

aqrln commented Jan 19, 2026

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing aqrln-tuxsotykylou (ba8b033) with aqrln-wuuzunwxxymx (1ee2b71)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.457MiB 3.463MiB -5.795KiB
Postgres (gzip) 1.130MiB 1.131MiB -781.000B
Postgres (size-optimized) 1.740MiB 1.741MiB -771.000B
Postgres (size-optimized, gzip) 685.129KiB 684.323KiB 826.000B
Mysql 3.410MiB 3.416MiB -5.958KiB
Mysql (gzip) 1.112MiB 1.113MiB -1.409KiB
Mysql (size-optimized) 1.710MiB 1.711MiB -1013.000B
Mysql (size-optimized, gzip) 674.036KiB 673.503KiB 545.000B
Sqlite 3.329MiB 3.336MiB -6.956KiB
Sqlite (gzip) 1.085MiB 1.086MiB -1.464KiB
Sqlite (size-optimized) 1.665MiB 1.666MiB -1.031KiB
Sqlite (size-optimized, gzip) 657.696KiB 656.721KiB 998.000B
SQL Server 3.552MiB 3.558MiB -5.795KiB
SQL Server (gzip) 1.148MiB 1.148MiB -270.000B
SQL Server (size-optimized) 1.741MiB 1.742MiB -764.000B
SQL Server (size-optimized, gzip) 688.199KiB 687.853KiB 354.000B
CockroachDB 3.507MiB 3.513MiB -5.795KiB
CockroachDB (gzip) 1.148MiB 1.149MiB -242.000B
CockroachDB (size-optimized) 1.764MiB 1.765MiB -774.000B
CockroachDB (size-optimized, gzip) 694.990KiB 694.695KiB 302.000B

@aqrln aqrln requested a review from jkomyno January 21, 2026 10:34
@graphite-app
Copy link

graphite-app bot commented Jan 28, 2026

Merge activity

Remove `ScalarCondition::InTemplate` and `ScalarCondition::NotInTemplate` and instead add placeholders as the third variant in `ConditionListValue`. This simplifies the implementation and makes some illegal states unrepresentable (previously it was possible to construct `ScalarCondition::InTemplate`/`ScalarCondition::NotInTemplate` with arbitrary `PrismaValue`s and with field references).
@graphite-app graphite-app bot force-pushed the aqrln-wuuzunwxxymx branch from fa74f5a to 1ee2b71 Compare January 28, 2026 13:35
@graphite-app graphite-app bot force-pushed the aqrln-tuxsotykylou branch from 3b6fbba to ba8b033 Compare January 28, 2026 13:35
Base automatically changed from aqrln-wuuzunwxxymx to main January 28, 2026 15:37
@graphite-app graphite-app bot merged commit ba8b033 into main Jan 28, 2026
97 checks passed
@graphite-app graphite-app bot deleted the aqrln-tuxsotykylou branch January 28, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments