refactor(qc): remove ScalarCondition::[Not]InTemplate#5735
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2026
Merged
refactor(qc): remove ScalarCondition::[Not]InTemplate#5735graphite-app[bot] merged 1 commit intomainfrom
ScalarCondition::[Not]InTemplate#5735graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Jan 19, 2026
Member
Author
This was referenced Jan 19, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
Wasm Query Compiler File Size
|
d8485ea to
fa74f5a
Compare
616c4c9 to
3b6fbba
Compare
This was referenced Jan 20, 2026
jkomyno
reviewed
Jan 21, 2026
jkomyno
reviewed
Jan 21, 2026
jkomyno
reviewed
Jan 21, 2026
jkomyno
approved these changes
Jan 21, 2026
jkomyno
approved these changes
Jan 21, 2026
Merge activity
|
Remove `ScalarCondition::InTemplate` and `ScalarCondition::NotInTemplate` and instead add placeholders as the third variant in `ConditionListValue`. This simplifies the implementation and makes some illegal states unrepresentable (previously it was possible to construct `ScalarCondition::InTemplate`/`ScalarCondition::NotInTemplate` with arbitrary `PrismaValue`s and with field references).
fa74f5a to
1ee2b71
Compare
3b6fbba to
ba8b033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remove
ScalarCondition::InTemplateandScalarCondition::NotInTemplateand instead add placeholders as the third variant inConditionListValue. This simplifies the implementation and makes some illegal states unrepresentable (previously it was possible to constructScalarCondition::InTemplate/ScalarCondition::NotInTemplatewith arbitraryPrismaValues and with field references).