Skip to content

refactor(qc): remove unused ScalarType::Param variant#5737

Merged
graphite-app[bot] merged 1 commit intomainfrom
aqrln-olpxkvsorwnv
Jan 28, 2026
Merged

refactor(qc): remove unused ScalarType::Param variant#5737
graphite-app[bot] merged 1 commit intomainfrom
aqrln-olpxkvsorwnv

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Jan 19, 2026

Remove unused ScalarType::Param.

This was intended to be used for schema-driver parameterization in the initial prototype but it would not have been an adequate representation, and we have now chosen a better way to mark fields as parameterizable.

Copy link
Member Author

aqrln commented Jan 19, 2026

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing aqrln-olpxkvsorwnv (3f83219) with aqrln-yqlsysspvylk (251611e)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.457MiB 3.457MiB -87.000B
Postgres (gzip) 1.130MiB 1.130MiB 129.000B
Postgres (size-optimized) 1.740MiB 1.740MiB -95.000B
Postgres (size-optimized, gzip) 685.447KiB 685.369KiB 80.000B
Mysql 3.410MiB 3.410MiB -87.000B
Mysql (gzip) 1.112MiB 1.112MiB 1.000B
Mysql (size-optimized) 1.710MiB 1.710MiB -95.000B
Mysql (size-optimized, gzip) 674.100KiB 674.098KiB 2.000B
Sqlite 3.329MiB 3.329MiB -87.000B
Sqlite (gzip) 1.085MiB 1.085MiB 5.000B
Sqlite (size-optimized) 1.665MiB 1.665MiB -95.000B
Sqlite (size-optimized, gzip) 657.791KiB 657.711KiB 81.000B
SQL Server 3.552MiB 3.552MiB -87.000B
SQL Server (gzip) 1.148MiB 1.148MiB 76.000B
SQL Server (size-optimized) 1.741MiB 1.741MiB -95.000B
SQL Server (size-optimized, gzip) 688.367KiB 688.292KiB 76.000B
CockroachDB 3.508MiB 3.508MiB -87.000B
CockroachDB (gzip) 1.149MiB 1.149MiB -8.000B
CockroachDB (size-optimized) 1.764MiB 1.764MiB -95.000B
CockroachDB (size-optimized, gzip) 695.008KiB 694.980KiB 29.000B

@aqrln aqrln changed the title refactor(qc): remove unused ScalarField::Param variant refactor(qc): remove unused ScalarType::Param variant Jan 19, 2026
@aqrln aqrln force-pushed the aqrln-yqlsysspvylk branch from 1cf37c7 to 3a94b8a Compare January 19, 2026 18:39
@aqrln aqrln force-pushed the aqrln-olpxkvsorwnv branch from 3d02d75 to 631d732 Compare January 19, 2026 18:39
@aqrln aqrln added this to the 7.3.0 milestone Jan 19, 2026
@aqrln aqrln marked this pull request as ready for review January 20, 2026 07:03
@aqrln aqrln requested a review from jkomyno January 20, 2026 11:43
@graphite-app
Copy link

graphite-app bot commented Jan 28, 2026

Merge activity

Remove unused `ScalarType::Param`.

This was intended to be used for schema-driver parameterization in the initial prototype but it would not have been an adequate representation, and we have now chosen a better way to mark fields as parameterizable.
@graphite-app graphite-app bot force-pushed the aqrln-yqlsysspvylk branch from 3a94b8a to 251611e Compare January 28, 2026 13:36
@graphite-app graphite-app bot force-pushed the aqrln-olpxkvsorwnv branch from 631d732 to 3f83219 Compare January 28, 2026 13:37
Base automatically changed from aqrln-yqlsysspvylk to main January 28, 2026 15:38
@graphite-app graphite-app bot merged commit 3f83219 into main Jan 28, 2026
90 checks passed
@graphite-app graphite-app bot deleted the aqrln-olpxkvsorwnv branch January 28, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments