Skip to content

refactor(qc): extract invalid argument type error factory#5740

Merged
graphite-app[bot] merged 1 commit intomainfrom
aqrln-olznqwotvklo
Jan 28, 2026
Merged

refactor(qc): extract invalid argument type error factory#5740
graphite-app[bot] merged 1 commit intomainfrom
aqrln-olznqwotvklo

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Jan 19, 2026

Extract the repetitive ValidationError::invalid_argument_type
construction code and mark it as #[inline(never)] to save some extra
bytes in the compiled binary since it's an error path and therefore not
performance critical.

Copy link
Member Author

aqrln commented Jan 19, 2026

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing aqrln-olznqwotvklo (2693e0a) with aqrln-tllupuwwnstq (2a0f5e2)

Summary

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.480MiB 3.482MiB -2.195KiB
Postgres (gzip) 1.138MiB 1.139MiB -27.000B
Postgres (size-optimized) 1.756MiB 1.756MiB -542.000B
Postgres (size-optimized, gzip) 690.965KiB 691.000KiB -35.000B
Mysql 3.433MiB 3.435MiB -2.195KiB
Mysql (gzip) 1.121MiB 1.121MiB -297.000B
Mysql (size-optimized) 1.725MiB 1.726MiB -542.000B
Mysql (size-optimized, gzip) 680.061KiB 680.276KiB -220.000B
Sqlite 3.352MiB 3.354MiB -2.195KiB
Sqlite (gzip) 1.094MiB 1.094MiB -103.000B
Sqlite (size-optimized) 1.681MiB 1.681MiB -542.000B
Sqlite (size-optimized, gzip) 662.973KiB 663.676KiB -720.000B
SQL Server 3.575MiB 3.577MiB -2.195KiB
SQL Server (gzip) 1.157MiB 1.157MiB -35.000B
SQL Server (size-optimized) 1.757MiB 1.757MiB -542.000B
SQL Server (size-optimized, gzip) 694.180KiB 694.325KiB -148.000B
CockroachDB 3.530MiB 3.532MiB -2.195KiB
CockroachDB (gzip) 1.158MiB 1.158MiB -143.000B
CockroachDB (size-optimized) 1.780MiB 1.780MiB -542.000B
CockroachDB (size-optimized, gzip) 700.915KiB 701.112KiB -202.000B

@graphite-app
Copy link

graphite-app bot commented Jan 28, 2026

Merge activity

Extract the repetitive `ValidationError::invalid_argument_type`
construction code and mark it as `#[inline(never)]` to save some extra
bytes in the compiled binary since it's an error path and therefore not
performance critical.
@graphite-app graphite-app bot force-pushed the aqrln-tllupuwwnstq branch from 7d79d28 to 2a0f5e2 Compare January 28, 2026 13:38
@graphite-app graphite-app bot force-pushed the aqrln-olznqwotvklo branch from da60deb to 2693e0a Compare January 28, 2026 13:38
Base automatically changed from aqrln-tllupuwwnstq to main January 28, 2026 15:40
@graphite-app graphite-app bot merged commit 2693e0a into main Jan 28, 2026
90 checks passed
@graphite-app graphite-app bot deleted the aqrln-olznqwotvklo branch January 28, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments