refactor(qc): extract invalid argument type error factory#5740
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2026
Merged
refactor(qc): extract invalid argument type error factory#5740graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Jan 19, 2026
Member
Author
This was referenced Jan 19, 2026
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Contributor
Wasm Query Compiler File Size
|
90018ac to
da60deb
Compare
33eec0c to
7d79d28
Compare
This was referenced Jan 20, 2026
jkomyno
approved these changes
Jan 21, 2026
Merge activity
|
Extract the repetitive `ValidationError::invalid_argument_type` construction code and mark it as `#[inline(never)]` to save some extra bytes in the compiled binary since it's an error path and therefore not performance critical.
7d79d28 to
2a0f5e2
Compare
da60deb to
2693e0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Extract the repetitive
ValidationError::invalid_argument_typeconstruction code and mark it as
#[inline(never)]to save some extrabytes in the compiled binary since it's an error path and therefore not
performance critical.