starknet_patricia_storage: always cache writes in cached storage#12443
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/flush-siblings-to-storagefrom
Open
Conversation
Contributor
Author
This was referenced Feb 10, 2026
b8c6929 to
f60e9a7
Compare
5e77e3c to
f073c3d
Compare
f60e9a7 to
a861514
Compare
f073c3d to
b8e2dc7
Compare
a861514 to
ac85e19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes core storage caching behavior and removes a configuration knob, which can affect performance/memory characteristics and cache semantics under write-heavy workloads.
Overview
CachedStoragenow always updates the LRU cache on write paths:setunconditionallyputs the written key/value andmsetflushes all written entries into the cache, removing the prior conditional behavior.This PR removes the
cache_on_writesetting end-to-end (storage config struct, config dumping/schema, CLI construction, tests, and deployment committer JSON configs), so caching-on-write is no longer configurable and is always enabled.Written by Cursor Bugbot for commit ac85e19. This will update automatically on new commits. Configure here.