Skip to content

starknet_patricia_storage: always cache writes in cached storage#12443

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/flush-siblings-to-storagefrom
nimrod/parallel-reads/always-cache-on-write
Open

starknet_patricia_storage: always cache writes in cached storage#12443
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/flush-siblings-to-storagefrom
nimrod/parallel-reads/always-cache-on-write

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 10, 2026

Note

Medium Risk
Changes core storage caching behavior and removes a configuration knob, which can affect performance/memory characteristics and cache semantics under write-heavy workloads.

Overview
CachedStorage now always updates the LRU cache on write paths: set unconditionally puts the written key/value and mset flushes all written entries into the cache, removing the prior conditional behavior.

This PR removes the cache_on_write setting end-to-end (storage config struct, config dumping/schema, CLI construction, tests, and deployment committer JSON configs), so caching-on-write is no longer configurable and is always enabled.

Written by Cursor Bugbot for commit ac85e19. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

nimrod-starkware commented Feb 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Feb 10, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review February 10, 2026 10:33
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/always-cache-on-write branch from b8c6929 to f60e9a7 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from 5e77e3c to f073c3d Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/always-cache-on-write branch from f60e9a7 to a861514 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from f073c3d to b8e2dc7 Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/always-cache-on-write branch from a861514 to ac85e19 Compare February 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments