Skip to content

starknet_committer_and_os_cli: build storage tries concurrently based on py config#12444

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/always-cache-on-writefrom
nimrod/parallel-reads/py-config
Open

starknet_committer_and_os_cli: build storage tries concurrently based on py config#12444
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/always-cache-on-writefrom
nimrod/parallel-reads/py-config

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 10, 2026

Note

Medium Risk
Changes input deserialization/schema and can flip on concurrent storage-trie construction, which may surface race/performance issues if downstream code isn’t concurrency-safe.

Overview
The committer CLI input format now includes a build_storage_tries_concurrently boolean in RawConfigImpl, and CommitterFactsDbInputImpl passes it through to ReaderConfig::new (removing the previous hardcoded false).

Tests were updated to include the new config field in the serialized input fixtures and to validate both true and false cases.

Written by Cursor Bugbot for commit a91dd91. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware self-assigned this Feb 10, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review February 10, 2026 10:33
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py side:
https://reviewable.io/reviews/starkware-industries/starkware/40161

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/always-cache-on-write branch from b8c6929 to f60e9a7 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/py-config branch from b4f2ba1 to a687f27 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/always-cache-on-write branch from f60e9a7 to a861514 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/py-config branch from a687f27 to 2f403ef Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/always-cache-on-write branch from a861514 to ac85e19 Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/py-config branch from 2f403ef to a91dd91 Compare February 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments