starknet_patricia_storage: extend the storage trait to optionally flush to cache

[nimrod-starkware]

Note

Low Risk
Small, additive API change with a default no-op implementation; main risk is minor breakage for downstream crates that implement Storage and need to recompile/update.

Overview
Adds a new optional Storage::flush_to_cache(DbHashMap) method (default no-op) so callers can prime caches without coupling to concrete storage types.

Implements the hook for CachedStorage by delegating to its existing flush_to_cache helper, and simplifies that helper to write directly into the LRU cache (removing the Arc::get_mut path).

^{Written by Cursor Bugbot for commit 206bc01. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_committer_config: validate config #12728
• starknet_committer_and_os_cli: build storage tries concurrently based on py config #12444
• starknet_patricia_storage: always cache writes in cached storage #12443
• starknet_committer: flush siblings into storage #12272
• starknet_committer: collect storage tries siblings #12271
• starknet_committer: collect siblings when traversing the tree #12270
• starknet_patricia_storage: extend the storage trait to optionally flush to cache #12269 👈 (View in Graphite)
• starknet_patricia_storage: flush explictly to cache #12267 : 1 other dependent PR (#12268 )
• starknet_committer: create storage tries based on config #12441
• starknet_committer: add a field indicating if storage tries should be created concurrently #12440
• starknet_committer: remove code dup for single trie #12201
• starknet_patricia_storage: remove code dup for mget #12175
• starknet_patricia_storage: spawn a task or not based on config #12174
• starknet_patricia_storage: add config field to rocksDB storage #12173
• starknet_patricia_storage: add config field to rocksDB #12172
• starknet_patricia_storage: spawn blocking tasks for rocksDB reads #12168 : 1 other dependent PR (#12169 )
• starknet_committer: parallel reads using unordered futures #12167
• starknet_committer: create sotrage tries sequentially #12166
• starknet_patricia,starknet_committer: dont pass storage mut when not needed #12165
• starknet_patricia_storage: non mut get in storage trait #12123 : 1 other dependent PR (#12252 )
• starknet_patricia_storage: dont cache reads in cached storage #12251
• starknet_patricia_storage: atomic counters for read stats #12122
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp reviewed 2 files and made 2 comments.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on nimrod-starkware).

---

crates/starknet_patricia_storage/src/map_storage.rs line 225 at r1 (raw file):

    }

    pub fn flush_to_cache(&mut self, map: DbHashMap) {

remove this and keep the login in the trait implementation

---

crates/starknet_patricia_storage/src/map_storage.rs line 322 at r1 (raw file):

        None::<NullStorage>
    }
    fn flush_to_cache(&mut self, map: DbHashMap) -> PatriciaStorageResult<()> {

newline + inline flush_to_cache below