starknet_patricia_storage: add config field to rocksDB#12172
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1d1a202 to
8c34bc5
Compare
5e6fccd to
7d77e0e
Compare
7d77e0e to
079d7cd
Compare
8c34bc5 to
0521001
Compare
079d7cd to
14776a9
Compare
0521001 to
7e803af
Compare
14776a9 to
4cd5e6e
Compare
4cd5e6e to
cfc584f
Compare
cfc584f to
f226763
Compare
8586da9 to
c9cbe45
Compare
fa24309 to
06e3a5a
Compare
c9cbe45 to
4391b31
Compare
06e3a5a to
16f87a8
Compare
| /// Whether to use mmap for reading SST files. | ||
| pub use_mmap_reads: bool, | ||
| /// Whether to spawn blocking tasks for read operations. | ||
| pub spawn_blocking_reads: bool, |
There was a problem hiding this comment.
Config field spawn_blocking_reads is never used
Low Severity
The new spawn_blocking_reads config field is added to RocksDbStorageConfig but is never read to control any runtime behavior. The get and mget methods unconditionally call spawn_blocking regardless of this setting. Additionally, the config isn't stored in RocksDbStorage (only RocksDbOptions is stored), so the field wouldn't be accessible even if conditional logic were added. Existing TODO comments on lines 291 and 302 explicitly note that the config should control whether to spawn blocking tasks, but this implementation doesn't connect the new field to that behavior.
4391b31 to
a0a8a84
Compare
16f87a8 to
5e43c56
Compare
5e43c56 to
52d8abf
Compare
a0a8a84 to
33d4bdf
Compare
52d8abf to
f4f22e8
Compare
33d4bdf to
a600409
Compare
a600409 to
d9b393f
Compare
f4f22e8 to
c0ff6d1
Compare
d9b393f to
a39458d
Compare
c0ff6d1 to
4e6ecd0
Compare
4e6ecd0 to
de721d6
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).



Note
Low Risk
Config-only plumbing with default behavior unchanged (
false), and no functional read-path logic changes in this PR.Overview
Adds a new RocksDB tuning parameter,
spawn_blocking_reads, toRocksDbStorageConfig(including defaults and config serialization) and exposes it via the node config schema.Updates deployment committer config templates (
committer_config.jsonandreplacer_committer_config.json) to include the newcommitter_config.storage_config.inner_storage_config.spawn_blocking_readsfield (defaultfalse).Written by Cursor Bugbot for commit de721d6. This will update automatically on new commits. Configure here.