Skip to content

starknet_patricia_storage: add config field to rocksDB#12172

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/spawn-blocking-readsfrom
nimrod/parallel-reads/add_spawn_blocking_reads_to_config
Open

starknet_patricia_storage: add config field to rocksDB#12172
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/spawn-blocking-readsfrom
nimrod/parallel-reads/add_spawn_blocking_reads_to_config

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 1, 2026

Note

Low Risk
Config-only plumbing with default behavior unchanged (false), and no functional read-path logic changes in this PR.

Overview
Adds a new RocksDB tuning parameter, spawn_blocking_reads, to RocksDbStorageConfig (including defaults and config serialization) and exposes it via the node config schema.

Updates deployment committer config templates (committer_config.json and replacer_committer_config.json) to include the new committer_config.storage_config.inner_storage_config.spawn_blocking_reads field (default false).

Written by Cursor Bugbot for commit de721d6. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 1, 2026

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/read-in-parallel-for-async-storage branch from 1d1a202 to 8c34bc5 Compare February 2, 2026 08:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 5e6fccd to 7d77e0e Compare February 2, 2026 08:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 7d77e0e to 079d7cd Compare February 2, 2026 09:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/read-in-parallel-for-async-storage branch from 8c34bc5 to 0521001 Compare February 3, 2026 13:08
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 079d7cd to 14776a9 Compare February 3, 2026 13:08
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/read-in-parallel-for-async-storage branch from 0521001 to 7e803af Compare February 3, 2026 14:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 14776a9 to 4cd5e6e Compare February 3, 2026 14:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 4cd5e6e to cfc584f Compare February 3, 2026 15:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from cfc584f to f226763 Compare February 4, 2026 11:51
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/read-in-parallel-for-async-storage branch from 8586da9 to c9cbe45 Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from fa24309 to 06e3a5a Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/read-in-parallel-for-async-storage branch from c9cbe45 to 4391b31 Compare February 9, 2026 15:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 06e3a5a to 16f87a8 Compare February 9, 2026 15:13
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

/// Whether to use mmap for reading SST files.
pub use_mmap_reads: bool,
/// Whether to spawn blocking tasks for read operations.
pub spawn_blocking_reads: bool,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config field spawn_blocking_reads is never used

Low Severity

The new spawn_blocking_reads config field is added to RocksDbStorageConfig but is never read to control any runtime behavior. The get and mget methods unconditionally call spawn_blocking regardless of this setting. Additionally, the config isn't stored in RocksDbStorage (only RocksDbOptions is stored), so the field wouldn't be accessible even if conditional logic were added. Existing TODO comments on lines 291 and 302 explicitly note that the config should control whether to spawn blocking tasks, but this implementation doesn't connect the new field to that behavior.

Fix in Cursor Fix in Web

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/read-in-parallel-for-async-storage branch from 4391b31 to a0a8a84 Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 16f87a8 to 5e43c56 Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware changed the base branch from nimrod/parallel-reads/read-in-parallel-for-async-storage to graphite-base/12172 February 10, 2026 09:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 5e43c56 to 52d8abf Compare February 10, 2026 09:07
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/12172 to nimrod/parallel-reads/spawn-blocking-reads February 10, 2026 09:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 52d8abf to f4f22e8 Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/spawn-blocking-reads branch from 33d4bdf to a600409 Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/spawn-blocking-reads branch from a600409 to d9b393f Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from f4f22e8 to c0ff6d1 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/spawn-blocking-reads branch from d9b393f to a39458d Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from c0ff6d1 to 4e6ecd0 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 4e6ecd0 to de721d6 Compare February 19, 2026 09:21
Copy link
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments