Skip to content

starknet_committer: add a field indicating if storage tries should be created concurrently#12440

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/remove-dup-storage-triefrom
nimrod/parallel-storage-tries/add_field_to_reader_config
Open

starknet_committer: add a field indicating if storage tries should be created concurrently#12440
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/remove-dup-storage-triefrom
nimrod/parallel-storage-tries/add_field_to_reader_config

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 10, 2026

Note

Low Risk
Adds a new boolean config field but defaults it to false everywhere; changes are mostly plumbing and test updates with minimal behavioral impact unless the flag is later enabled.

Overview
Adds a new ReaderConfig flag, build_storage_tries_concurrently, to control whether storage tries are built concurrently vs sequentially, including serialization and a public accessor.

Wires the new setting through config artifacts (committer_config.json, replacer_committer_config.json, and config_schema.json) and updates CLI input parsing/tests to pass the additional ReaderConfig::new parameter (currently hardcoded to false in the CLI with a TODO).

Written by Cursor Bugbot for commit 86e286c. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 10, 2026

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

config: ReaderConfig::new(
raw_input.config.warn_on_trivial_modifications,
build_storage_tries_concurrently,
),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI ignores concurrency reader config

Medium Severity

parse_input hardcodes build_storage_tries_concurrently to false when creating ReaderConfig. Because RawInput/RawConfigImpl has no corresponding field, the CLI path cannot carry this new setting and always runs the sequential behavior, even after adding build_storage_tries_concurrently to committer configuration.

Fix in Cursor Fix in Web

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-storage-tries/add_field_to_reader_config branch from b410637 to 54d46e7 Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-dup-storage-trie branch from 5af1469 to 5175a12 Compare February 19, 2026 09:21
Copy link
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-dup-storage-trie branch from 5175a12 to c31ac25 Compare February 19, 2026 13:47
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-storage-tries/add_field_to_reader_config branch from 54d46e7 to 86e286c Compare February 19, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments