starknet_committer: add a field indicating if storage tries should be created concurrently#12440
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/remove-dup-storage-triefrom
Conversation
This was referenced Feb 10, 2026
This was referenced Feb 10, 2026
Contributor
Author
This was referenced Feb 10, 2026
This was referenced Feb 10, 2026
342077c to
7c15a96
Compare
15840f2 to
b410637
Compare
7c15a96 to
5af1469
Compare
| config: ReaderConfig::new( | ||
| raw_input.config.warn_on_trivial_modifications, | ||
| build_storage_tries_concurrently, | ||
| ), |
There was a problem hiding this comment.
CLI ignores concurrency reader config
Medium Severity
parse_input hardcodes build_storage_tries_concurrently to false when creating ReaderConfig. Because RawInput/RawConfigImpl has no corresponding field, the CLI path cannot carry this new setting and always runs the sequential behavior, even after adding build_storage_tries_concurrently to committer configuration.
b410637 to
54d46e7
Compare
5af1469 to
5175a12
Compare
ArielElp
approved these changes
Feb 19, 2026
Contributor
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).
… created concurrently
5175a12 to
c31ac25
Compare
54d46e7 to
86e286c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Note
Low Risk
Adds a new boolean config field but defaults it to
falseeverywhere; changes are mostly plumbing and test updates with minimal behavioral impact unless the flag is later enabled.Overview
Adds a new
ReaderConfigflag,build_storage_tries_concurrently, to control whether storage tries are built concurrently vs sequentially, including serialization and a public accessor.Wires the new setting through config artifacts (
committer_config.json,replacer_committer_config.json, andconfig_schema.json) and updates CLI input parsing/tests to pass the additionalReaderConfig::newparameter (currently hardcoded tofalsein the CLI with a TODO).Written by Cursor Bugbot for commit 86e286c. This will update automatically on new commits. Configure here.