starknet_patricia_storage: flush explictly to cache#12267
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-storage-tries/parallel_based_on_configfrom
Open
starknet_patricia_storage: flush explictly to cache#12267nimrod-starkware wants to merge 1 commit intonimrod/parallel-storage-tries/parallel_based_on_configfrom
nimrod-starkware wants to merge 1 commit intonimrod/parallel-storage-tries/parallel_based_on_configfrom
Conversation
This was referenced Feb 4, 2026
This was referenced Feb 4, 2026
Contributor
Author
This was referenced Feb 4, 2026
b1c945d to
464262a
Compare
35b357d to
dd43526
Compare
464262a to
589d52b
Compare
This was referenced Feb 9, 2026
This was referenced Feb 9, 2026
dd43526 to
df90d58
Compare
0517529 to
5fc9927
Compare
57e4671 to
dddb7d7
Compare
5fc9927 to
8f17cc1
Compare
dddb7d7 to
ea60323
Compare
8f17cc1 to
7a53b42
Compare
This was referenced Feb 10, 2026
Open
7a53b42 to
6f9605d
Compare
ea60323 to
0e6beb1
Compare
This was referenced Feb 10, 2026
b79b0e7 to
8fde07e
Compare
1e445a0 to
a662b3c
Compare
8fde07e to
cc406a4
Compare
ArielElp
requested changes
Feb 19, 2026
Contributor
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).
crates/starknet_patricia_storage/src/map_storage.rs line 227 at r1 (raw file):
pub fn flush_to_cache(&mut self, map: DbHashMap) { let cache = Arc::get_mut(&mut self.cache).expect("Failed to get mutable reference to cache.");
We no longer need Arc::get_mut, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Introduces a new mutable cache update path that bulk-inserts entries and can change runtime caching behavior; it also uses
Arc::get_mut(...).expect(...), so incorrect sharing assumptions could cause panics.Overview
CachedStoragegains a newflush_to_cache(map: DbHashMap)method that explicitly bulk-populates the LRU cache with a set of key/value pairs, bypassing the existing per-write caching behavior.This enables callers to proactively warm/refresh the cache from a batch map rather than relying on
set/msetupdates only.Written by Cursor Bugbot for commit cc406a4. This will update automatically on new commits. Configure here.