Skip to content

starknet_patricia_storage: add config field to rocksDB storage#12173

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/add_spawn_blocking_reads_to_configfrom
nimrod/parallel-reads/config-field
Open

starknet_patricia_storage: add config field to rocksDB storage#12173
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/add_spawn_blocking_reads_to_configfrom
nimrod/parallel-reads/config-field

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 1, 2026

Note

Low Risk
Small, additive change that only stores extra state and doesn’t alter read/write behavior or on-disk data handling.

Overview
RocksDbStorage now retains a copy of the passed RocksDbStorageConfig via a new private _config field, and RocksDbStorage::new populates it when constructing the storage.

No behavior changes are introduced yet; this mainly preserves configuration state for potential future use (e.g., toggles like spawn_blocking_reads).

Written by Cursor Bugbot for commit fdf98af. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 1, 2026

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from ff7c5e0 to 87029a0 Compare February 2, 2026 08:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 5e6fccd to 7d77e0e Compare February 2, 2026 08:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from 87029a0 to a594575 Compare February 2, 2026 09:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 7d77e0e to 079d7cd Compare February 2, 2026 09:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch 2 times, most recently from a8d8b53 to 7b94b0e Compare February 3, 2026 14:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 14776a9 to 4cd5e6e Compare February 3, 2026 14:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 4cd5e6e to cfc584f Compare February 3, 2026 15:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from 7b94b0e to bcc7298 Compare February 3, 2026 15:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from f226763 to fa24309 Compare February 5, 2026 08:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch 2 times, most recently from ee9db12 to 17fb5a6 Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from fa24309 to 06e3a5a Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 06e3a5a to 16f87a8 Compare February 9, 2026 15:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch 2 times, most recently from 04de417 to 93549f6 Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 5e43c56 to 52d8abf Compare February 10, 2026 09:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from 93549f6 to 001b426 Compare February 10, 2026 09:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 52d8abf to f4f22e8 Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from 001b426 to 67b6567 Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from 67b6567 to fa080d5 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from f4f22e8 to c0ff6d1 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from c0ff6d1 to 4e6ecd0 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from fa080d5 to 03cf6b6 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/add_spawn_blocking_reads_to_config branch from 4e6ecd0 to de721d6 Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/config-field branch from 03cf6b6 to fdf98af Compare February 19, 2026 09:21
Copy link
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments