starknet_patricia_storage: add config field to rocksDB storage#12173
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/add_spawn_blocking_reads_to_configfrom
Open
Conversation
This was referenced Feb 1, 2026
Contributor
Author
This was referenced Feb 1, 2026
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ff7c5e0 to
87029a0
Compare
5e6fccd to
7d77e0e
Compare
87029a0 to
a594575
Compare
7d77e0e to
079d7cd
Compare
a8d8b53 to
7b94b0e
Compare
14776a9 to
4cd5e6e
Compare
4cd5e6e to
cfc584f
Compare
7b94b0e to
bcc7298
Compare
f226763 to
fa24309
Compare
ee9db12 to
17fb5a6
Compare
fa24309 to
06e3a5a
Compare
This was referenced Feb 9, 2026
06e3a5a to
16f87a8
Compare
04de417 to
93549f6
Compare
5e43c56 to
52d8abf
Compare
93549f6 to
001b426
Compare
52d8abf to
f4f22e8
Compare
001b426 to
67b6567
Compare
This was referenced Feb 10, 2026
Open
67b6567 to
fa080d5
Compare
f4f22e8 to
c0ff6d1
Compare
c0ff6d1 to
4e6ecd0
Compare
fa080d5 to
03cf6b6
Compare
4e6ecd0 to
de721d6
Compare
03cf6b6 to
fdf98af
Compare
ArielElp
approved these changes
Feb 19, 2026
Contributor
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Small, additive change that only stores extra state and doesn’t alter read/write behavior or on-disk data handling.
Overview
RocksDbStoragenow retains a copy of the passedRocksDbStorageConfigvia a new private_configfield, andRocksDbStorage::newpopulates it when constructing the storage.No behavior changes are introduced yet; this mainly preserves configuration state for potential future use (e.g., toggles like
spawn_blocking_reads).Written by Cursor Bugbot for commit fdf98af. This will update automatically on new commits. Configure here.