starknet_patricia_storage: remove code dup for mget

[nimrod-starkware]

Note

Low Risk
Pure refactor confined to RocksDB batch-read code; behavior should be unchanged aside from potential edge-case differences in iterator/key types passed to multi_get.

Overview
Refactors RocksDbStorage::mget to remove duplicated multi_get/error-mapping logic by introducing a shared helper mget_from_raw_keys.

Both the spawn_blocking and direct-read branches now call this helper, keeping behavior the same while centralizing the result conversion and error handling.

^{Written by Cursor Bugbot for commit 4ef3e58. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_patricia_storage: flush explictly to cache #12267 : 2 dependent PRs (#12268 , #12269 )
• starknet_committer: create storage tries based on config #12441
• starknet_committer: add a field indicating if storage tries should be created concurrently #12440
• starknet_committer: remove code dup for single trie #12201
• starknet_patricia_storage: remove code dup for mget #12175 👈 (View in Graphite)
• starknet_patricia_storage: spawn a task or not based on config #12174
• starknet_patricia_storage: add config field to rocksDB storage #12173
• starknet_patricia_storage: add config field to rocksDB #12172
• starknet_patricia_storage: spawn blocking tasks for rocksDB reads #12168 : 1 other dependent PR (#12169 )
• starknet_committer: parallel reads using unordered futures #12167
• starknet_committer: create sotrage tries sequentially #12166
• starknet_patricia,starknet_committer: dont pass storage mut when not needed #12165
• starknet_patricia_storage: non mut get in storage trait #12123 : 1 other dependent PR (#12252 )
• starknet_patricia_storage: dont cache reads in cached storage #12251
• starknet_patricia_storage: atomic counters for read stats #12122
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on nimrod-starkware).

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 266 at r1 (raw file):

    }

    fn mget_from_raw_keys<K: AsRef<[u8]>, RK: IntoIterator<Item = K>>(

consider the proposal from the previous PR:

fn multi_get(
    db: &DB,
    keys: impl IntoIterator<Item = impl AsRef<[u8]>>,
) -> Result<Vec<Option<DbValue>>, PatriciaStorageError> {
    db.multi_get(keys)
        .into_iter()
        .map(|r| r.map(|opt| opt.map(DbValue)).map_err(|e| e.into()))
        .collect()
}

no new generics here

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 272 at r1 (raw file):

        db.multi_get(raw_keys)
            .into_iter()
            .map(|r| r.map(|opt| opt.map(DbValue)).map_err(|e| e.into()))

I think things compile without it

Code quote:

map_err(|e| e.into()

[ArielElp]

@ArielElp reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on nimrod-starkware).