starknet_committer: create storage tries based on config

[nimrod-starkware]

Note

Medium Risk
Introduces optional concurrency into trie-building, which can change runtime behavior and stress shared Storage implementations; correctness should remain the same but races/resource contention are possible depending on storage backends.

Overview
create_storage_tries now switches between sequential and concurrent construction based on ReaderConfig::build_storage_tries_concurrently() instead of always running sequentially.

This wires in the existing create_storage_tries_concurrently implementation (and removes its dead-code allowance) and adds/updates docstrings to reflect the new config-driven behavior.

^{Written by Cursor Bugbot for commit 9c549d1. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_patricia_storage: flush explictly to cache #12267 : 2 dependent PRs (#12268 , #12269 )
• starknet_committer: create storage tries based on config #12441 👈 (View in Graphite)
• starknet_committer: add a field indicating if storage tries should be created concurrently #12440
• starknet_committer: remove code dup for single trie #12201
• starknet_patricia_storage: remove code dup for mget #12175
• starknet_patricia_storage: spawn a task or not based on config #12174
• starknet_patricia_storage: add config field to rocksDB storage #12173
• starknet_patricia_storage: add config field to rocksDB #12172
• starknet_patricia_storage: spawn blocking tasks for rocksDB reads #12168 : 1 other dependent PR (#12169 )
• starknet_committer: parallel reads using unordered futures #12167
• starknet_committer: create sotrage tries sequentially #12166
• starknet_patricia,starknet_committer: dont pass storage mut when not needed #12165
• starknet_patricia_storage: non mut get in storage trait #12123 : 1 other dependent PR (#12252 )
• starknet_patricia_storage: dont cache reads in cached storage #12251
• starknet_patricia_storage: atomic counters for read stats #12122
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on nimrod-starkware).

---

crates/starknet_committer/src/db/trie_traversal.rs line 341 at r1 (raw file):

}

/// Creates the original skeleton trees of the storage tries of modified contracts.

modified storage tries.

Code quote:

the storage tries of modified contracts

---

crates/starknet_committer/src/db/trie_traversal.rs line 355 at r1 (raw file):

        HasStaticPrefix<KeyContext = ContractAddress>,
{
    match config.build_storage_tries_concurrently() {

Use if/else to branch on a bool