Skip to content

starknet_committer: collect siblings when traversing the tree#12270

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/flush-cache-storage-traitfrom
nimrod/parallel-reads/gather-siblings
Open

starknet_committer: collect siblings when traversing the tree#12270
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/flush-cache-storage-traitfrom
nimrod/parallel-reads/gather-siblings

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 4, 2026

Note

Low Risk
Behavior is unchanged for existing callers (they pass None); the new logic only activates when a siblings_map is provided, with the main risk being extra memory/IO retention if misused.

Overview
Extends create_original_skeleton_tree/fetch_nodes traversal to optionally collect DB entries for unmodified sibling subtrees while fetching roots from storage.

This threads a new optional siblings_map: Option<&mut DbHashMap> through get_roots_from_storage and callers; when provided, get_roots_from_storage records the (DbKey, DbValue) for any subtree marked is_unmodified(). All existing call sites (including facts DB traversal and tests) are updated to pass None, preserving current behavior by default.

Written by Cursor Bugbot for commit 01a8289. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware self-assigned this Feb 4, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review February 4, 2026 12:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from 1c8972d to fd2936d Compare February 4, 2026 13:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from c1769a1 to 63b6032 Compare February 4, 2026 13:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch 2 times, most recently from f1271ca to dbb2555 Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from 180e776 to 6fb0189 Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from dbb2555 to f431b8a Compare February 9, 2026 15:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from 6fb0189 to e39bb60 Compare February 9, 2026 15:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from f431b8a to 559eca8 Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from e39bb60 to 5d9789c Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from 559eca8 to e216af0 Compare February 10, 2026 09:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from 7ae348e to 79b85ab Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from e216af0 to 573730b Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from 79b85ab to 64731a2 Compare February 10, 2026 10:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from 573730b to 2c07fec Compare February 10, 2026 10:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from 2c07fec to 7cbb953 Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch 2 times, most recently from 62e5f98 to f54d0f8 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from 7cbb953 to eb15c30 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-cache-storage-trait branch from f54d0f8 to 206bc01 Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/gather-siblings branch from eb15c30 to 01a8289 Compare February 19, 2026 09:21
@ArielElp ArielElp self-requested a review February 19, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments