starknet_committer: collect siblings when traversing the tree#12270
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/flush-cache-storage-traitfrom
Open
Conversation
This was referenced Feb 4, 2026
This was referenced Feb 4, 2026
Contributor
Author
1c8972d to
fd2936d
Compare
c1769a1 to
63b6032
Compare
f1271ca to
dbb2555
Compare
180e776 to
6fb0189
Compare
This was referenced Feb 9, 2026
dbb2555 to
f431b8a
Compare
6fb0189 to
e39bb60
Compare
f431b8a to
559eca8
Compare
e39bb60 to
5d9789c
Compare
559eca8 to
e216af0
Compare
7ae348e to
79b85ab
Compare
e216af0 to
573730b
Compare
79b85ab to
64731a2
Compare
573730b to
2c07fec
Compare
This was referenced Feb 10, 2026
2c07fec to
7cbb953
Compare
62e5f98 to
f54d0f8
Compare
7cbb953 to
eb15c30
Compare
f54d0f8 to
206bc01
Compare
eb15c30 to
01a8289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Behavior is unchanged for existing callers (they pass
None); the new logic only activates when asiblings_mapis provided, with the main risk being extra memory/IO retention if misused.Overview
Extends
create_original_skeleton_tree/fetch_nodestraversal to optionally collect DB entries for unmodified sibling subtrees while fetching roots from storage.This threads a new optional
siblings_map: Option<&mut DbHashMap>throughget_roots_from_storageand callers; when provided,get_roots_from_storagerecords the(DbKey, DbValue)for any subtree markedis_unmodified(). All existing call sites (including facts DB traversal and tests) are updated to passNone, preserving current behavior by default.Written by Cursor Bugbot for commit 01a8289. This will update automatically on new commits. Configure here.