starknet_committer: create sotrage tries sequentially#12166
starknet_committer: create sotrage tries sequentially#12166nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/no-mutfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
60c43c9 to
aff17da
Compare
3a0da1d to
9416084
Compare
7020fae to
ab6c75f
Compare
9416084 to
59d3f11
Compare
59d3f11 to
511535e
Compare
ab6c75f to
1cc055f
Compare
1cc055f to
cc3622f
Compare
d371458 to
9ec087b
Compare
65c3d46 to
0c646b9
Compare
2c1f122 to
27025e8
Compare
9cfd0bf to
3d46c52
Compare
27025e8 to
927724f
Compare
927724f to
01d2b5b
Compare
0176a59 to
9847b21
Compare
01d2b5b to
2a03926
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).
9847b21 to
d902d2b
Compare
2a03926 to
2520ad4
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).
2520ad4 to
7488c1e
Compare
d902d2b to
48dd3a9
Compare
7488c1e to
e819a39
Compare
e819a39 to
83ce3ba
Compare

Note
Low Risk
Pure refactor that extracts existing logic into a helper with no functional changes expected; risk is limited to accidental signature/flow regressions in storage-trie construction.
Overview
Refactors
create_storage_triesby moving its per-contract loop into a new private helper,create_storage_tries_sequentially, and delegating to it.Behavior is intended to be unchanged: it still iterates through
actual_storage_updates, looks up sorted leaf indices and prior contract state, and builds an original skeleton storage trie per contract before returning the map.Written by Cursor Bugbot for commit 83ce3ba. This will update automatically on new commits. Configure here.