Skip to content

starknet_committer: create sotrage tries sequentially#12166

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/no-mutfrom
nimrod/parallel-reads/sequentially
Open

starknet_committer: create sotrage tries sequentially#12166
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/no-mutfrom
nimrod/parallel-reads/sequentially

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 1, 2026

Note

Low Risk
Pure refactor that extracts existing logic into a helper with no functional changes expected; risk is limited to accidental signature/flow regressions in storage-trie construction.

Overview
Refactors create_storage_tries by moving its per-contract loop into a new private helper, create_storage_tries_sequentially, and delegating to it.

Behavior is intended to be unchanged: it still iterates through actual_storage_updates, looks up sorted leaf indices and prior contract state, and builds an original skeleton storage trie per contract before returning the map.

Written by Cursor Bugbot for commit 83ce3ba. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 1, 2026

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@nimrod-starkware nimrod-starkware self-assigned this Feb 1, 2026
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 60c43c9 to aff17da Compare February 1, 2026 08:49
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from 3a0da1d to 9416084 Compare February 1, 2026 09:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch 2 times, most recently from 7020fae to ab6c75f Compare February 1, 2026 09:29
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from 9416084 to 59d3f11 Compare February 1, 2026 09:29
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from 59d3f11 to 511535e Compare February 1, 2026 11:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from ab6c75f to 1cc055f Compare February 1, 2026 11:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 1cc055f to cc3622f Compare February 2, 2026 08:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch 2 times, most recently from d371458 to 9ec087b Compare February 3, 2026 14:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from 65c3d46 to 0c646b9 Compare February 3, 2026 14:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 2c1f122 to 27025e8 Compare February 5, 2026 08:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from 9cfd0bf to 3d46c52 Compare February 5, 2026 08:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 27025e8 to 927724f Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 927724f to 01d2b5b Compare February 9, 2026 15:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch 2 times, most recently from 0176a59 to 9847b21 Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 01d2b5b to 2a03926 Compare February 10, 2026 08:44
Copy link
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from 9847b21 to d902d2b Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 2a03926 to 2520ad4 Compare February 10, 2026 12:34
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 2520ad4 to 7488c1e Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/no-mut branch from d902d2b to 48dd3a9 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/sequentially branch from 7488c1e to e819a39 Compare February 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments