Skip to content

starknet_patricia_storage: non mut get in storage trait#12123

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/dont-cache-readsfrom
nimrod/parallel-reads/non-mut-get
Open

starknet_patricia_storage: non mut get in storage trait#12123
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/dont-cache-readsfrom
nimrod/parallel-reads/non-mut-get

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jan 29, 2026

Note

Medium Risk
Trait signature change touches all storage backends and wrappers, so breakage risk is mostly around compilation/behavioral assumptions (e.g., caching or interior mutability) rather than data correctness.

Overview
Updates the Storage trait so read operations (get/mget) take &self instead of &mut self, making reads callable from shared references and better aligned with concurrent access patterns.

Propagates the new signature across all storage implementations and wrappers (Aerospike, RocksDB, MDBX, MapStorage, CachedStorage, short-key wrappers, and NullStorage), and adjusts call sites/tests/benchmark interference code to stop requiring mutable clones solely for reads.

Written by Cursor Bugbot for commit 8ee2dc3. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Jan 29, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-reads-from-cached-storage branch from 41cc5f2 to 3ebf9db Compare January 29, 2026 08:58
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch 3 times, most recently from 069d687 to 5e1127c Compare January 29, 2026 09:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-reads-from-cached-storage branch from 3ebf9db to 7091357 Compare February 1, 2026 09:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from 5e1127c to 76ee609 Compare February 1, 2026 09:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-reads-from-cached-storage branch from 7091357 to d58cd4a Compare February 1, 2026 09:29
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from 76ee609 to a360e7f Compare February 1, 2026 09:29
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-reads-from-cached-storage branch from d58cd4a to f899e10 Compare February 1, 2026 11:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from a360e7f to 71c52d3 Compare February 1, 2026 11:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/remove-reads-from-cached-storage branch from f899e10 to df1d000 Compare February 2, 2026 08:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from 71c52d3 to b50a0d9 Compare February 2, 2026 08:36
Copy link
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

Copy link
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielElp reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/dont-cache-reads branch from fa31e81 to 8e3541d Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from d50807e to 82c0e32 Compare February 10, 2026 12:34
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/dont-cache-reads branch from 8e3541d to 40845b0 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from 82c0e32 to 42bb057 Compare February 17, 2026 07:13
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/dont-cache-reads branch from 40845b0 to cd93f36 Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/non-mut-get branch from 42bb057 to 8ee2dc3 Compare February 19, 2026 09:21
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments