Skip to content

starknet_committer: flush siblings into storage#12272

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-siblingsfrom
nimrod/parallel-reads/flush-siblings-to-storage
Open

starknet_committer: flush siblings into storage#12272
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-siblingsfrom
nimrod/parallel-reads/flush-siblings-to-storage

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 4, 2026

Note

Medium Risk
Touches core state-read/trie-traversal code and introduces new side effects (cache writes) during reads, which could impact correctness/perf if sibling collection is incomplete or oversized.

Overview
While building the original skeleton forest, trie traversal now collects the DB entries for unmodified sibling nodes (contracts trie, per-contract storage tries, and classes trie) and then flushes them into the storage cache via Storage::flush_to_cache.

This changes the read_forest API to take &mut Storage and updates create_contracts_trie/create_classes_trie to return sibling maps, so the read path can batch cache population after all traversals complete.

Written by Cursor Bugbot for commit b8e2dc7. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware self-assigned this Feb 4, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review February 4, 2026 12:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from f414f89 to 672b038 Compare February 4, 2026 13:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from cadbc01 to 854cf32 Compare February 4, 2026 13:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from 672b038 to 7e92187 Compare February 5, 2026 08:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from 854cf32 to 859642a Compare February 5, 2026 08:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from 7e92187 to 885e303 Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from 859642a to 753c0c2 Compare February 9, 2026 14:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from 753c0c2 to 9d2dcf7 Compare February 9, 2026 15:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from 228570c to f7dfb43 Compare February 10, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch 2 times, most recently from b51365d to 963bd63 Compare February 10, 2026 09:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch 2 times, most recently from 6fd8367 to 14998f9 Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from 963bd63 to 00eddd6 Compare February 10, 2026 09:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from 14998f9 to f80bd52 Compare February 10, 2026 10:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from 00eddd6 to 1f2ecd0 Compare February 10, 2026 10:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from f80bd52 to d43d14c Compare February 10, 2026 12:34
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch 2 times, most recently from 5e77e3c to f073c3d Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from d43d14c to 5657561 Compare February 17, 2026 07:13
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-siblings branch from 5657561 to cc80f8c Compare February 19, 2026 09:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/flush-siblings-to-storage branch from f073c3d to b8e2dc7 Compare February 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments