starknet_committer: flush siblings into storage#12272
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-siblingsfrom
Open
starknet_committer: flush siblings into storage#12272nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-siblingsfrom
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-siblingsfrom
Conversation
This was referenced Feb 4, 2026
This was referenced Feb 4, 2026
Contributor
Author
f414f89 to
672b038
Compare
cadbc01 to
854cf32
Compare
672b038 to
7e92187
Compare
854cf32 to
859642a
Compare
7e92187 to
885e303
Compare
859642a to
753c0c2
Compare
This was referenced Feb 9, 2026
753c0c2 to
9d2dcf7
Compare
228570c to
f7dfb43
Compare
b51365d to
963bd63
Compare
6fd8367 to
14998f9
Compare
963bd63 to
00eddd6
Compare
14998f9 to
f80bd52
Compare
00eddd6 to
1f2ecd0
Compare
This was referenced Feb 10, 2026
f80bd52 to
d43d14c
Compare
5e77e3c to
f073c3d
Compare
d43d14c to
5657561
Compare
5657561 to
cc80f8c
Compare
f073c3d to
b8e2dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches core state-read/trie-traversal code and introduces new side effects (cache writes) during reads, which could impact correctness/perf if sibling collection is incomplete or oversized.
Overview
While building the original skeleton forest, trie traversal now collects the DB entries for unmodified sibling nodes (contracts trie, per-contract storage tries, and classes trie) and then flushes them into the storage cache via
Storage::flush_to_cache.This changes the
read_forestAPI to take&mut Storageand updatescreate_contracts_trie/create_classes_trieto return sibling maps, so the read path can batch cache population after all traversals complete.Written by Cursor Bugbot for commit b8e2dc7. This will update automatically on new commits. Configure here.