starknet_patricia,starknet_committer: dont pass storage mut when not needed

[nimrod-starkware]

Note

Low Risk
Signature-only refactor to relax mutability requirements with no logic changes; risk is limited to compile-time integration fallout or overlooked call sites.

Overview
Removes unnecessary mutable borrows of storage throughout original-skeleton-tree and Patricia traversal read paths by changing function signatures from &mut impl Storage/&mut MapStorage to &impl Storage/&MapStorage (e.g., create_original_skeleton_tree, fetch_nodes, get_roots_from_storage, facts traversal, and forest read_forest).

Updates all callers in facts/index DB readers, OS commitment-info generation, proof fetching, and tests to match the new immutability expectations, including minor test cleanup (dropping mut locals/params) and a TODO noting ForestReader could also move to &self.

^{Written by Cursor Bugbot for commit 16085da. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_patricia_storage: spawn blocking tasks for rocksDB reads #12168 : 2 dependent PRs (#12169 , #12172 )
• starknet_committer: parallel reads using unordered futures #12167
• starknet_committer: create sotrage tries sequentially #12166
• starknet_patricia,starknet_committer: dont pass storage mut when not needed #12165 👈 (View in Graphite)
• starknet_patricia_storage: non mut get in storage trait #12123 : 1 other dependent PR (#12252 )
• starknet_patricia_storage: dont cache reads in cached storage #12251
• starknet_patricia_storage: atomic counters for read stats #12122
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[ArielElp]

@ArielElp reviewed 12 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 14 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 9 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on nimrod-starkware).