starknet_patricia_storage: spawn a task or not based on config

[nimrod-starkware]

Note

Medium Risk
Changes the runtime execution model for storage reads (threadpool vs async runtime), which can affect latency/throughput and potential runtime blocking if misconfigured.

Overview
Makes RocksDB read offloading configurable. RocksDbStorage now stores RocksDbStorageConfig and conditionally uses tokio::spawn_blocking for get/mget only when spawn_blocking_reads is enabled; otherwise reads execute directly.

Config defaults and deployment configs are updated to set committer_config.storage_config.inner_storage_config.spawn_blocking_reads to true, and the config schema default is changed accordingly.

^{Written by Cursor Bugbot for commit 695d081. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_patricia_storage: flush explictly to cache #12267 : 2 dependent PRs (#12268 , #12269 )
• starknet_committer: create storage tries based on config #12441
• starknet_committer: add a field indicating if storage tries should be created concurrently #12440
• starknet_committer: remove code dup for single trie #12201
• starknet_patricia_storage: remove code dup for mget #12175
• starknet_patricia_storage: spawn a task or not based on config #12174 👈 (View in Graphite)
• starknet_patricia_storage: add config field to rocksDB storage #12173
• starknet_patricia_storage: add config field to rocksDB #12172
• starknet_patricia_storage: spawn blocking tasks for rocksDB reads #12168 : 1 other dependent PR (#12169 )
• starknet_committer: parallel reads using unordered futures #12167
• starknet_committer: create sotrage tries sequentially #12166
• starknet_patricia,starknet_committer: dont pass storage mut when not needed #12165
• starknet_patricia_storage: non mut get in storage trait #12123 : 1 other dependent PR (#12252 )
• starknet_patricia_storage: dont cache reads in cached storage #12251
• starknet_patricia_storage: atomic counters for read stats #12122
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[ArielElp]

@ArielElp reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nimrod-starkware).

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 315 at r2 (raw file):

                    .map(|r| r.map(|opt| opt.map(DbValue)).map_err(|e| e.into()))
                    .collect::<Result<Vec<_>, PatriciaStorageError>>()
            })

can you factor this out into a function and call it in both cases? Cursor suggested:

fn multi_get(
    db: &DB,
    keys: impl IntoIterator<Item = impl AsRef<[u8]>>,
) -> Result<Vec<Option<DbValue>>, PatriciaStorageError> {
    db.multi_get(keys)
        .into_iter()
        .map(|r| r.map(|opt| opt.map(DbValue)).map_err(|e| e.into()))
        .collect()
}

        if self.config.spawn_blocking_reads {
            let db = self.db.clone();
            let keys: Vec<Vec<u8>> = keys.iter().map(|k| k.0.clone()).collect();
            Ok(spawn_blocking(move || multi_get(&db, keys.iter().map(|k| k.as_slice())))
                .await??)
        } else {
            Ok(multi_get(&self.db, keys.iter().map(|k| k.0.as_slice()))?)
        }

Code quote:

            let db = self.db.clone();
            let keys: Vec<Vec<u8>> = keys.iter().map(|k| k.0.clone()).collect();
            Ok(spawn_blocking(move || {
                let raw_keys = keys.iter().map(|k| k.as_slice());
                db.multi_get(raw_keys)
                    .into_iter()
                    .map(|r| r.map(|opt| opt.map(DbValue)).map_err(|e| e.into()))
                    .collect::<Result<Vec<_>, PatriciaStorageError>>()
            })

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 315 at r2 (raw file):

Previously, ArielElp wrote…

can you factor this out into a function and call it in both cases? Cursor suggested:

fn multi_get(
    db: &DB,
    keys: impl IntoIterator<Item = impl AsRef<[u8]>>,
) -> Result<Vec<Option<DbValue>>, PatriciaStorageError> {
    db.multi_get(keys)
        .into_iter()
        .map(|r| r.map(|opt| opt.map(DbValue)).map_err(|e| e.into()))
        .collect()
}

        if self.config.spawn_blocking_reads {
            let db = self.db.clone();
            let keys: Vec<Vec<u8>> = keys.iter().map(|k| k.0.clone()).collect();
            Ok(spawn_blocking(move || multi_get(&db, keys.iter().map(|k| k.as_slice())))
                .await??)
        } else {
            Ok(multi_get(&self.db, keys.iter().map(|k| k.0.as_slice()))?)
        }

Done in next PR