Skip to content

apollo_committer_config: validate config#12728

Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/py-configfrom
nimrod/parallel-reads/commiter-config-validation
Open

apollo_committer_config: validate config#12728
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/py-configfrom
nimrod/parallel-reads/commiter-config-validation

Conversation

@nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Feb 19, 2026

Note

Low Risk
Limited to configuration validation and import/type tweaks; main risk is rejecting previously-accepted invalid config combinations at startup.

Overview
Adds explicit Validate support for the concrete committer config (CommitterConfig<CachedStorageConfig<RocksDbStorageConfig>>) instead of deriving it generically.

Validation now (1) delegates to the nested storage_config.validate() and (2) enforces a cross-field constraint: when reader_config.build_storage_tries_concurrently is enabled, storage_config.inner_storage_config.spawn_blocking_reads must also be true (otherwise validation fails with a ValidationErrors entry).

Written by Cursor Bugbot for commit 8a11f44. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

nimrod-starkware commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/commiter-config-validation branch from bf9f4d4 to d0ff4f3 Compare February 19, 2026 13:47
@nimrod-starkware nimrod-starkware self-assigned this Feb 19, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review February 19, 2026 13:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/commiter-config-validation branch from d0ff4f3 to 8a11f44 Compare February 19, 2026 14:12
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/py-config branch from 642ea0b to 4e65158 Compare February 19, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments