apollo_committer_config: validate config#12728
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/py-configfrom
Open
apollo_committer_config: validate config#12728nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/py-configfrom
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/py-configfrom
Conversation
This was referenced Feb 19, 2026
Contributor
Author
bf9f4d4 to
d0ff4f3
Compare
d0ff4f3 to
8a11f44
Compare
642ea0b to
4e65158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Limited to configuration validation and import/type tweaks; main risk is rejecting previously-accepted invalid config combinations at startup.
Overview
Adds explicit
Validatesupport for the concrete committer config (CommitterConfig<CachedStorageConfig<RocksDbStorageConfig>>) instead of deriving it generically.Validation now (1) delegates to the nested
storage_config.validate()and (2) enforces a cross-field constraint: whenreader_config.build_storage_tries_concurrentlyis enabled,storage_config.inner_storage_config.spawn_blocking_readsmust also be true (otherwise validation fails with aValidationErrorsentry).Written by Cursor Bugbot for commit 8a11f44. This will update automatically on new commits. Configure here.