starknet_committer: read in parallel for supported storages

[nimrod-starkware]

Note

Medium Risk
Introduces conditional parallelism in trie reads; while it’s read-only, concurrency can surface latent thread-safety/ordering issues in specific storage implementations and may change performance characteristics.

Overview
create_storage_tries now conditionally builds per-contract storage trie skeletons concurrently when the underlying Storage exposes an async-capable instance via get_async_self(), falling back to the existing sequential path otherwise.

This refactors create_storage_tries_concurrently to accept a Storage reference (dropping the explicit AsyncStorage bound and previous cloning) while keeping the same skeleton-tree construction behavior for each modified contract.

^{Written by Cursor Bugbot for commit a0a8a84. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_committer: read in parallel for supported storages #12169 👈 (View in Graphite)
• starknet_patricia_storage: spawn blocking tasks for rocksDB reads #12168 : 1 other dependent PR (#12172 )
• starknet_committer: parallel reads using unordered futures #12167
• starknet_committer: create sotrage tries sequentially #12166
• starknet_patricia,starknet_committer: dont pass storage mut when not needed #12165
• starknet_patricia_storage: non mut get in storage trait #12123 : 1 other dependent PR (#12252 )
• starknet_patricia_storage: dont cache reads in cached storage #12251
• starknet_patricia_storage: atomic counters for read stats #12122
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

Dead code annotation remains after function becomes used

Low Severity

This change starts calling create_storage_tries_concurrently, but the function definition at lines 481-482 still has #[allow(dead_code)] with a TODO comment saying "Remove the allow(dead_code) once we use this function." Since the function is now used, this annotation and its accompanying TODO comment are now stale and potentially confusing to future developers.