chore: Add Generals 1.07 and Zero Hour 1.04 retail game data#2
chore: Add Generals 1.07 and Zero Hour 1.04 retail game data#2Stubbjax wants to merge 13 commits intoTheSuperHackers:mainfrom
Conversation
|
Zero Hour Patch 1.01 diff loooks unexpected. It adds a lot of new INI files which should have existed in 1.00 |
I also wondered about this and triple-checked, but that is indeed what my |
|
Ok wow. This change needs to be merged with rebase. Will you add pull id to commits or leave as is? |
Stubbjax
force-pushed
the
add-retail-game-data
branch
from
f5f7ce7 to
b5ef554
Compare
|
The expected final Generals version is 1.08 |
The final data patch for Generals is 1.07 though. The version number described in each commit directly corresponds to the changes for that particular version. What do you propose? |
|
Ok so I suspect this means in Generals 1.08 there were only changes not related to STR, WND, INI? It would be good to clarify this somehow as one may think the version is not latest. |
That is correct. See here: https://cnc.fandom.com/wiki/Generals_patch_1.08 How should it be clarified? In the PR description or title? |
|
Yes you can add a second sentence clarifying that it matches 1.08 |
|
Update was not pushed. |
You mean add a second sentence to the respective commit and not the PR description? |
|
Yes, so that it is noted in the commit history. |
|
Also, instead of writing "retail game data" perhaps be more specific and say which kind of files are added, because "retail game data" includes way more files than just INI, STR, WND |
…ckers#2) Note: Version 1.07 is the latest official data patch for Generals. Version 1.08 made no changes to the respective data.
Stubbjax
force-pushed
the
add-retail-game-data
branch
from
b5ef554 to
95bc6db
Compare
GeneralsZH/Data/generals.str
Outdated
| DIALOGEVENT:Taunts_BossChi030Subtitle | ||
| US: "*Suicide is not a tactic, General" | ||
| DIALOGEVENT:Taunts_BossGLA083Subtitle | ||
| US: "*Selling off your buildings to fund your army? Hardly seems logical, does it, General" |
There was a problem hiding this comment.
Something is not right with the diff at chore: Add retail INI, STR and WND data for Zero Hour 1.01. Also the commit after that.
Also I suggest to check the final entries order of generals.str matches the one in GeneralsGamePatch' generals.str, for ease of integrations.
There was a problem hiding this comment.
What is not right? And did we not want to split generals.str into separate files?
There was a problem hiding this comment.
The diff looks suspicious. Why does it show so many swapped out lines?
There was a problem hiding this comment.
I imagine they added entries which causes the diff look like everything is replaced.
There was a problem hiding this comment.
It looks like some entries moved position. The diff shows GUI:Retaliation removed on one line and added to another. It is awful for reviewing the changes.
2 participants
This change adds Generals 1.07 and Zero Hour 1.04 retail game data. This includes all
.ini,.strand.wndfiles. The.strdata is combined from all available languages into the onegenerals.strfile (andautorun.strfor some languages) for each game.Note: Generals 1.07 is the latest official data patch and gameplay is identical with Generals 1.08. See here for more information.